From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35130)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1alccX-0007do-2j
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:26:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1alccS-00053S-3h
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:26:45 -0400
Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:32804)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1alccR-00053H-M3
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:26:40 -0400
Received: by mail-wm0-x22b.google.com with SMTP id f198so1127230wme.0
	for <qemu-devel@nongnu.org>; Thu, 31 Mar 2016 06:26:39 -0700 (PDT)
References: <1458196505-5473-1-git-send-email-famz@redhat.com>
	<1458196505-5473-8-git-send-email-famz@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1458196505-5473-8-git-send-email-famz@redhat.com>
Date: Thu, 31 Mar 2016 14:26:41 +0100
Message-ID: <87ziteg4mm.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 07/13] docker: Add full test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, jsnow@redhat.com, david@gibson.dropbear.id.au


Fam Zheng <famz@redhat.com> writes:

> This builds all available targets.

I'm not sure what this adds over the quick test that couldn't be
achieved with the configure defaulting to an empty target list. I'm easy
either way but I'm thinking test-quick and test-full could be merged
into test-simple and default to all targets, default configure.

It can then be tweaked for specific subsets and extra configure options
with the extra parameters.

>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/test-full | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100755 tests/docker/test-full
>
> diff --git a/tests/docker/test-full b/tests/docker/test-full
> new file mode 100755
> index 0000000..fd9b798
> --- /dev/null
> +++ b/tests/docker/test-full
> @@ -0,0 +1,17 @@
> +#!/bin/bash -e
> +#
> +# Compile all the targets.
> +#
> +# Copyright (c) 2016 Red Hat Inc.
> +#
> +# Authors:
> +#  Fam Zheng <famz@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2
> +# or (at your option) any later version. See the COPYING file in
> +# the top-level directory.
> +
> +. common.rc
> +
> +build_qemu
> +make check $MAKEFLAGS


--
Alex Bennée