From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Do not put big intel_crtc_state on the stack Date: Thu, 21 Jan 2016 11:47:17 +0200 Message-ID: <87zivzuuvu.fsf@intel.com> References: <1453217117-26125-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 8551F6E208 for ; Thu, 21 Jan 2016 01:47:19 -0800 (PST) In-Reply-To: <1453217117-26125-1-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxOSBKYW4gMjAxNiwgVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KPgo+IEhhdmluZyB0aGlzIG9uIHN0YWNrIHRyaWdnZXJzIHRoZSAtV2ZyYW1l LWxhcmdlci10aGFuPTEwMjQgYW5kCj4gaXMgbm90IG5pY2UgdG8gcHV0IHN1Y2ggYmlnIHRoaW5n cyBvbiB0aGUga2VybmVsIHN0YWNrIGFueXdheS4KPgo+IFRoaXMgcmVxdWlyZWQgYSBsaXR0bGUg Yml0IG9mIHJlZmFjdG9yaW5nIHRvIGhhbmRsZSB0aGUgbmV3Cj4gZmFpbHVyZSBwYXRoIGZyb20g dmx2X2ZvcmNlX3BsbF9vbi4KPgo+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA ZmZ3bGwuY2g+Cj4gQ2M6IEpvaG4gSGFycmlzb24gPGpvaG4uYy5oYXJyaXNvbkBpbnRlbC5jb20+ Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g LS0tCj4gQ29tcGlsZSB0ZXN0ZWQgb25seSEKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jIHwgNTggKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgICB8ICA4ICsrKy0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICA0ICstLQo+ICAzIGZpbGVzIGNo YW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGNjYjNlM2Y0NzQ1MC4uN2JmMTg2NThjNjU5IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC03NjM1LDI2ICs3NjM1 LDM0IEBAIHN0YXRpYyB2b2lkIGNodl9wcmVwYXJlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YywKPiAgICogaW4gY2FzZXMgd2hlcmUgd2UgbmVlZCB0aGUgUExMIGVuYWJsZWQgZXZlbiB3aGVu IEBwaXBlIGlzIG5vdCBnb2luZyB0bwo+ICAgKiBiZSBlbmFibGVkLgo+ICAgKi8KPiAtdm9pZCB2 bHZfZm9yY2VfcGxsX29uKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGVudW0gcGlwZSBwaXBlLAo+ ICtpbnQgdmx2X2ZvcmNlX3BsbF9vbihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBlbnVtIHBpcGUg cGlwZSwKPiAgCQkgICAgICBjb25zdCBzdHJ1Y3QgZHBsbCAqZHBsbCkKPiAgewo+ICAJc3RydWN0 IGludGVsX2NydGMgKmNydGMgPQo+ICAJCXRvX2ludGVsX2NydGMoaW50ZWxfZ2V0X2NydGNfZm9y X3BpcGUoZGV2LCBwaXBlKSk7Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSBwaXBlX2NvbmZp ZyA9IHsKPiAtCQkuYmFzZS5jcnRjID0gJmNydGMtPmJhc2UsCj4gLQkJLnBpeGVsX211bHRpcGxp ZXIgPSAxLAo+IC0JCS5kcGxsID0gKmRwbGwsCj4gLQl9Owo+ICsJc3RydWN0IGludGVsX2NydGNf c3RhdGUgKnBpcGVfY29uZmlnOwo+ICsKPiArCXBpcGVfY29uZmlnID0ga3phbGxvYyhzaXplb2Yo KnBpcGVfY29uZmlnKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIXBpcGVfY29uZmlnKQo+ICsJCXJl dHVybiAtRU5PTUVNOwo+ICsKPiArCXBpcGVfY29uZmlnLT5iYXNlLmNydGMgPSAmY3J0Yy0+YmFz ZTsKPiArCXBpcGVfY29uZmlnLT5waXhlbF9tdWx0aXBsaWVyID0gMTsKPiArCXBpcGVfY29uZmln LT5kcGxsID0gKmRwbGw7Cj4gIAo+ICAJaWYgKElTX0NIRVJSWVZJRVcoZGV2KSkgewo+IC0JCWNo dl9jb21wdXRlX2RwbGwoY3J0YywgJnBpcGVfY29uZmlnKTsKPiAtCQljaHZfcHJlcGFyZV9wbGwo Y3J0YywgJnBpcGVfY29uZmlnKTsKPiAtCQljaHZfZW5hYmxlX3BsbChjcnRjLCAmcGlwZV9jb25m aWcpOwo+ICsJCWNodl9jb21wdXRlX2RwbGwoY3J0YywgcGlwZV9jb25maWcpOwo+ICsJCWNodl9w cmVwYXJlX3BsbChjcnRjLCBwaXBlX2NvbmZpZyk7Cj4gKwkJY2h2X2VuYWJsZV9wbGwoY3J0Yywg cGlwZV9jb25maWcpOwo+ICAJfSBlbHNlIHsKPiAtCQl2bHZfY29tcHV0ZV9kcGxsKGNydGMsICZw aXBlX2NvbmZpZyk7Cj4gLQkJdmx2X3ByZXBhcmVfcGxsKGNydGMsICZwaXBlX2NvbmZpZyk7Cj4g LQkJdmx2X2VuYWJsZV9wbGwoY3J0YywgJnBpcGVfY29uZmlnKTsKPiArCQl2bHZfY29tcHV0ZV9k cGxsKGNydGMsIHBpcGVfY29uZmlnKTsKPiArCQl2bHZfcHJlcGFyZV9wbGwoY3J0YywgcGlwZV9j b25maWcpOwo+ICsJCXZsdl9lbmFibGVfcGxsKGNydGMsIHBpcGVfY29uZmlnKTsKPiAgCX0KPiAr Cj4gKwlrZnJlZShwaXBlX2NvbmZpZyk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIC8q Kgo+IEBAIC0xMDgyOCw3ICsxMDgzNiw3IEBAIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICppbnRl bF9jcnRjX21vZGVfZ2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlzdHJ1Y3QgaW50ZWxf Y3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gIAllbnVtIHRyYW5zY29k ZXIgY3B1X3RyYW5zY29kZXIgPSBpbnRlbF9jcnRjLT5jb25maWctPmNwdV90cmFuc2NvZGVyOwo+ ICAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSBwaXBlX2NvbmZpZzsKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZp ZzsKPiAgCWludCBodG90ID0gSTkxNV9SRUFEKEhUT1RBTChjcHVfdHJhbnNjb2RlcikpOwo+ICAJ aW50IGhzeW5jID0gSTkxNV9SRUFEKEhTWU5DKGNwdV90cmFuc2NvZGVyKSk7Cj4gIAlpbnQgdnRv dCA9IEk5MTVfUkVBRChWVE9UQUwoY3B1X3RyYW5zY29kZXIpKTsKPiBAQCAtMTA4MzksNiArMTA4 NDcsMTIgQEAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmludGVsX2NydGNfbW9kZV9nZXQoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCWlmICghbW9kZSkKPiAgCQlyZXR1cm4gTlVMTDsKPiAg Cj4gKwlwaXBlX2NvbmZpZyA9IGt6YWxsb2Moc2l6ZW9mKCpwaXBlX2NvbmZpZyksIEdGUF9LRVJO RUwpOwoKR0ZQX1RFTVBPUkFSWQoKQlIsCkphbmkuCgo+ICsJaWYgKCFwaXBlX2NvbmZpZykgewo+ ICsJCWtmcmVlKG1vZGUpOwo+ICsJCXJldHVybiBOVUxMOwo+ICsJfQo+ICsKPiAgCS8qCj4gIAkg KiBDb25zdHJ1Y3QgYSBwaXBlX2NvbmZpZyBzdWZmaWNpZW50IGZvciBnZXR0aW5nIHRoZSBjbG9j ayBpbmZvCj4gIAkgKiBiYWNrIG91dCBvZiBjcnRjX2Nsb2NrX2dldC4KPiBAQCAtMTA4NDYsMTQg KzEwODYwLDE0IEBAIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICppbnRlbF9jcnRjX21vZGVfZ2V0 KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkgKiBOb3RlLCBpZiBMVkRTIGV2ZXIgdXNlcyBh IG5vbi0xIHBpeGVsIG11bHRpcGxpZXIsIHdlJ2xsIG5lZWQKPiAgCSAqIHRvIHVzZSBhIHJlYWwg dmFsdWUgaGVyZSBpbnN0ZWFkLgo+ICAJICovCj4gLQlwaXBlX2NvbmZpZy5jcHVfdHJhbnNjb2Rl ciA9IChlbnVtIHRyYW5zY29kZXIpIHBpcGU7Cj4gLQlwaXBlX2NvbmZpZy5waXhlbF9tdWx0aXBs aWVyID0gMTsKPiAtCXBpcGVfY29uZmlnLmRwbGxfaHdfc3RhdGUuZHBsbCA9IEk5MTVfUkVBRChE UExMKHBpcGUpKTsKPiAtCXBpcGVfY29uZmlnLmRwbGxfaHdfc3RhdGUuZnAwID0gSTkxNV9SRUFE KEZQMChwaXBlKSk7Cj4gLQlwaXBlX2NvbmZpZy5kcGxsX2h3X3N0YXRlLmZwMSA9IEk5MTVfUkVB RChGUDEocGlwZSkpOwo+IC0JaTl4eF9jcnRjX2Nsb2NrX2dldChpbnRlbF9jcnRjLCAmcGlwZV9j b25maWcpOwo+IC0KPiAtCW1vZGUtPmNsb2NrID0gcGlwZV9jb25maWcucG9ydF9jbG9jayAvIHBp cGVfY29uZmlnLnBpeGVsX211bHRpcGxpZXI7Cj4gKwlwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29k ZXIgPSAoZW51bSB0cmFuc2NvZGVyKSBwaXBlOwo+ICsJcGlwZV9jb25maWctPnBpeGVsX211bHRp cGxpZXIgPSAxOwo+ICsJcGlwZV9jb25maWctPmRwbGxfaHdfc3RhdGUuZHBsbCA9IEk5MTVfUkVB RChEUExMKHBpcGUpKTsKPiArCXBpcGVfY29uZmlnLT5kcGxsX2h3X3N0YXRlLmZwMCA9IEk5MTVf UkVBRChGUDAocGlwZSkpOwo+ICsJcGlwZV9jb25maWctPmRwbGxfaHdfc3RhdGUuZnAxID0gSTkx NV9SRUFEKEZQMShwaXBlKSk7Cj4gKwlpOXh4X2NydGNfY2xvY2tfZ2V0KGludGVsX2NydGMsIHBp cGVfY29uZmlnKTsKPiArCj4gKwltb2RlLT5jbG9jayA9IHBpcGVfY29uZmlnLT5wb3J0X2Nsb2Nr IC8gcGlwZV9jb25maWctPnBpeGVsX211bHRpcGxpZXI7Cj4gIAltb2RlLT5oZGlzcGxheSA9ICho dG90ICYgMHhmZmZmKSArIDE7Cj4gIAltb2RlLT5odG90YWwgPSAoKGh0b3QgJiAweGZmZmYwMDAw KSA+PiAxNikgKyAxOwo+ICAJbW9kZS0+aHN5bmNfc3RhcnQgPSAoaHN5bmMgJiAweGZmZmYpICsg MTsKPiBAQCAtMTA4NjUsNiArMTA4NzksOCBAQCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqaW50 ZWxfY3J0Y19tb2RlX2dldChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAKPiAgCWRybV9tb2Rl X3NldF9uYW1lKG1vZGUpOwo+ICAKPiArCWtmcmVlKHBpcGVfY29uZmlnKTsKPiArCj4gIAlyZXR1 cm4gbW9kZTsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCAxNzYxMjU0 OGM1OGQuLmUyYmVhNzEwNjE0ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC0z MzUsOCArMzM1LDEyIEBAIHZsdl9wb3dlcl9zZXF1ZW5jZXJfa2ljayhzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwKQo+ICAJCXJlbGVhc2VfY2xfb3ZlcnJpZGUgPSBJU19DSEVSUllWSUVXKGRldikg JiYKPiAgCQkJIWNodl9waHlfcG93ZXJnYXRlX2NoKGRldl9wcml2LCBwaHksIGNoLCB0cnVlKTsK PiAgCj4gLQkJdmx2X2ZvcmNlX3BsbF9vbihkZXYsIHBpcGUsIElTX0NIRVJSWVZJRVcoZGV2KSA/ Cj4gLQkJCQkgJmNodl9kcGxsWzBdLmRwbGwgOiAmdmx2X2RwbGxbMF0uZHBsbCk7Cj4gKwkJaWYg KHZsdl9mb3JjZV9wbGxfb24oZGV2LCBwaXBlLCBJU19DSEVSUllWSUVXKGRldikgPwo+ICsJCQkJ ICAgICAmY2h2X2RwbGxbMF0uZHBsbCA6ICZ2bHZfZHBsbFswXS5kcGxsKSkgewo+ICsJCQlEUk1f RVJST1IoIkZhaWxlZCB0byBmb3JjZSBvbiBwbGwgZm9yIHBpcGUgJWMhXG4iLAo+ICsJCQkJICBw aXBlX25hbWUocGlwZSkpOwo+ICsJCQlyZXR1cm47Cj4gKwkJfQo+ICAJfQo+ICAKPiAgCS8qCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCAwNTliNDZlMjJjMzEuLjUzOGZhYWY0ZWVl ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTExNzcsOCArMTE3Nyw4IEBA IHZvaWQgYXNzZXJ0X3NoYXJlZF9kcGxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiAgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICppbnRlbF9nZXRfc2hhcmVkX2RwbGwoc3Ry dWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJCQkJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpz dGF0ZSk7Cj4gIAo+IC12b2lkIHZsdl9mb3JjZV9wbGxfb24oc3RydWN0IGRybV9kZXZpY2UgKmRl diwgZW51bSBwaXBlIHBpcGUsCj4gLQkJICAgICAgY29uc3Qgc3RydWN0IGRwbGwgKmRwbGwpOwo+ ICtpbnQgdmx2X2ZvcmNlX3BsbF9vbihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBlbnVtIHBpcGUg cGlwZSwKPiArCQkgICAgIGNvbnN0IHN0cnVjdCBkcGxsICpkcGxsKTsKPiAgdm9pZCB2bHZfZm9y Y2VfcGxsX29mZihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBlbnVtIHBpcGUgcGlwZSk7Cj4gIAo+ ICAvKiBtb2Rlc2V0dGluZyBhc3NlcnRzICovCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==