All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>, <peter.senna@gmail.com>
Cc: "Geyslan G. Bem" <geyslan@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Johan Hovold <johan@kernel.org>,
	Robert Baldyga <r.baldyga@samsung.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: remove redundant conditions
Date: Thu, 10 Dec 2015 08:50:10 -0600	[thread overview]
Message-ID: <87zixijr31.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <1449712366-31365-1-git-send-email-geyslan@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]


Hi,

"Geyslan G. Bem" <geyslan@gmail.com> writes:
> This patch removes redundant conditions.
>
>  - (!A || (A && B)) is the same as (!A || B).
>  - (length && length > 5) can be reduced to a single evaluation.
>
> Caught by: cppcheck
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>

Can you split this into one patch per driver, that way it's easier to
apply by different maintainers.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

  parent reply	other threads:[~2015-12-10 14:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10  1:52 [PATCH] usb: remove redundant conditions Geyslan G. Bem
2015-12-10 10:44 ` Johan Hovold
2015-12-10 10:50   ` Geyslan G. Bem
2015-12-10 14:50 ` Felipe Balbi [this message]
2015-12-10 14:58   ` Geyslan G. Bem
2015-12-10 15:13 ` Felipe Balbi
2015-12-10 15:16   ` Geyslan G. Bem
2015-12-10 15:37     ` Felipe Balbi
2015-12-10 15:17   ` David Laight
2015-12-10 15:29     ` Geyslan G. Bem
2015-12-10 15:35       ` Geyslan G. Bem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zixijr31.fsf@saruman.tx.rr.com \
    --to=balbi@ti.com \
    --cc=geyslan@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.senna@gmail.com \
    --cc=r.baldyga@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.