From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZoBcl-0003PQ-TH for ath10k@lists.infradead.org; Mon, 19 Oct 2015 14:41:20 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: Disable PCI PS for QCA988X and QCA99X0 References: <1443445278-11051-1-git-send-email-akolli@qti.qualcomm.com> Date: Mon, 19 Oct 2015 17:40:40 +0300 In-Reply-To: <1443445278-11051-1-git-send-email-akolli@qti.qualcomm.com> (akolli@qti.qualcomm.com's message of "Mon, 28 Sep 2015 18:31:18 +0530") Message-ID: <87zizegbvb.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: akolli@qti.qualcomm.com Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org writes: > From: Anilkumar Kolli > > This patch disables PCI PS for QCA988X and QCA99X0, Since PCI PS is > validated for QCA6174, let it be enabled only for QCA6174. It would be > better to execute PCI PS related functions only for the supported devices. > > PCI time out issue is observed with QCA99X0 on x86 platform, We will > disable PCI PS for QCA988X and QCA99X0 until PCI PS is properly implemented. > > Taking and releasing ps_lock is causing higher CPU consumption. Michal Kazior > suggested ps_lock overhead to be reworked so that ath10k_pci_wake/sleep > functions are called less often, i.e. move the powersave logic up (only during > irq handling, tx path, submitting fw commands). > > Signed-off-by: Anilkumar Kolli Applied, thanks. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:51418 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbbJSOk7 (ORCPT ); Mon, 19 Oct 2015 10:40:59 -0400 From: Kalle Valo To: CC: , Subject: Re: [PATCH] ath10k: Disable PCI PS for QCA988X and QCA99X0 References: <1443445278-11051-1-git-send-email-akolli@qti.qualcomm.com> Date: Mon, 19 Oct 2015 17:40:40 +0300 In-Reply-To: <1443445278-11051-1-git-send-email-akolli@qti.qualcomm.com> (akolli@qti.qualcomm.com's message of "Mon, 28 Sep 2015 18:31:18 +0530") Message-ID: <87zizegbvb.fsf@kamboji.qca.qualcomm.com> (sfid-20151019_164103_667145_881644CB) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: writes: > From: Anilkumar Kolli > > This patch disables PCI PS for QCA988X and QCA99X0, Since PCI PS is > validated for QCA6174, let it be enabled only for QCA6174. It would be > better to execute PCI PS related functions only for the supported devices. > > PCI time out issue is observed with QCA99X0 on x86 platform, We will > disable PCI PS for QCA988X and QCA99X0 until PCI PS is properly implemented. > > Taking and releasing ps_lock is causing higher CPU consumption. Michal Kazior > suggested ps_lock overhead to be reworked so that ath10k_pci_wake/sleep > functions are called less often, i.e. move the powersave logic up (only during > irq handling, tx path, submitting fw commands). > > Signed-off-by: Anilkumar Kolli Applied, thanks. -- Kalle Valo