From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] vgaarb: use kzalloc in vga_arbiter_add_pci_device() Date: Thu, 01 Oct 2015 11:26:40 +0300 Message-ID: <87zj03ata7.fsf@intel.com> References: <1443643027-4301-1-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CE186ECEB for ; Thu, 1 Oct 2015 01:23:21 -0700 (PDT) In-Reply-To: <1443643027-4301-1-git-send-email-linux@rasmusvillemoes.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAzMCBTZXAgMjAxNSwgUmFzbXVzIFZpbGxlbW9lcyA8bGludXhAcmFzbXVzdmlsbGVt b2VzLmRrPiB3cm90ZToKPiBTaWduZWQtb2ZmLWJ5OiBSYXNtdXMgVmlsbGVtb2VzIDxsaW51eEBy YXNtdXN2aWxsZW1vZXMuZGs+CgpSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxh QGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L3ZnYS92Z2FhcmIuYyB8IDQgKy0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvdmdhL3ZnYWFyYi5jIGIvZHJpdmVycy9ncHUvdmdhL3ZnYWFy Yi5jCj4gaW5kZXggYTBiNDMzNDU2MTA3Li4zMTY2ZTRiYzRlYjYgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvdmdhL3ZnYWFyYi5jCj4gKysrIGIvZHJpdmVycy9ncHUvdmdhL3ZnYWFyYi5jCj4g QEAgLTUzMSw3ICs1MzEsNyBAQCBzdGF0aWMgYm9vbCB2Z2FfYXJiaXRlcl9hZGRfcGNpX2Rldmlj ZShzdHJ1Y3QgcGNpX2RldiAqcGRldikKPiAgCQlyZXR1cm4gZmFsc2U7Cj4gIAo+ICAJLyogQWxs b2NhdGUgc3RydWN0dXJlICovCj4gLQl2Z2FkZXYgPSBrbWFsbG9jKHNpemVvZihzdHJ1Y3Qgdmdh X2RldmljZSksIEdGUF9LRVJORUwpOwo+ICsJdmdhZGV2ID0ga3phbGxvYyhzaXplb2Yoc3RydWN0 IHZnYV9kZXZpY2UpLCBHRlBfS0VSTkVMKTsKPiAgCWlmICh2Z2FkZXYgPT0gTlVMTCkgewo+ICAJ CXByX2VycigiZmFpbGVkIHRvIGFsbG9jYXRlIHBjaSBkZXZpY2VcbiIpOwo+ICAJCS8qCj4gQEAg LTU0MSw4ICs1NDEsNiBAQCBzdGF0aWMgYm9vbCB2Z2FfYXJiaXRlcl9hZGRfcGNpX2RldmljZShz dHJ1Y3QgcGNpX2RldiAqcGRldikKPiAgCQlyZXR1cm4gZmFsc2U7Cj4gIAl9Cj4gIAo+IC0JbWVt c2V0KHZnYWRldiwgMCwgc2l6ZW9mKCp2Z2FkZXYpKTsKPiAtCj4gIAkvKiBUYWtlIGxvY2sgJiBj aGVjayBmb3IgZHVwbGljYXRlcyAqLwo+ICAJc3Bpbl9sb2NrX2lycXNhdmUoJnZnYV9sb2NrLCBm bGFncyk7Cj4gIAlpZiAodmdhZGV2X2ZpbmQocGRldikgIT0gTlVMTCkgewo+IC0tIAo+IDIuMS4z Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoK LS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751798AbbJAIX2 (ORCPT ); Thu, 1 Oct 2015 04:23:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:44981 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755996AbbJAIXV (ORCPT ); Thu, 1 Oct 2015 04:23:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,616,1437462000"; d="scan'208";a="816926143" From: Jani Nikula To: Rasmus Villemoes , David Airlie Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] vgaarb: use kzalloc in vga_arbiter_add_pci_device() In-Reply-To: <1443643027-4301-1-git-send-email-linux@rasmusvillemoes.dk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1443643027-4301-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Notmuch/0.20.2+101~gb57168b (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 01 Oct 2015 11:26:40 +0300 Message-ID: <87zj03ata7.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015, Rasmus Villemoes wrote: > Signed-off-by: Rasmus Villemoes Reviewed-by: Jani Nikula > --- > drivers/gpu/vga/vgaarb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c > index a0b433456107..3166e4bc4eb6 100644 > --- a/drivers/gpu/vga/vgaarb.c > +++ b/drivers/gpu/vga/vgaarb.c > @@ -531,7 +531,7 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev) > return false; > > /* Allocate structure */ > - vgadev = kmalloc(sizeof(struct vga_device), GFP_KERNEL); > + vgadev = kzalloc(sizeof(struct vga_device), GFP_KERNEL); > if (vgadev == NULL) { > pr_err("failed to allocate pci device\n"); > /* > @@ -541,8 +541,6 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev) > return false; > } > > - memset(vgadev, 0, sizeof(*vgadev)); > - > /* Take lock & check for duplicates */ > spin_lock_irqsave(&vga_lock, flags); > if (vgadev_find(pdev) != NULL) { > -- > 2.1.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center