From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in intel_lrc.c Date: Wed, 16 Sep 2015 17:04:56 +0300 Message-ID: <87zj0mtq7r.fsf@intel.com> References: <8648ce6f3580053f73967453b119696c21622e05.1442347520.git.geliangtang@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <8648ce6f3580053f73967453b119696c21622e05.1442347520.git.geliangtang@163.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxNSBTZXAgMjAxNSwgR2VsaWFuZyBUYW5nIDxnZWxpYW5ndGFuZ0AxNjMuY29tPiB3 cm90ZToKPiBGaXggdGhlIGZvbGxvd2luZyAnbWFrZSBodG1sZG9jcycgd2FybmluZ3M6Cj4KPiAg IC4vL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jOjc4MDogd2FybmluZzogTm8gZGVz Y3JpcHRpb24gZm91bmQgZm9yIHBhcmFtZXRlciAncmVxJwo+ICAgLi8vZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfbHJjLmM6NzgwOiB3YXJuaW5nOiBFeGNlc3MgZnVuY3Rpb24gcGFyYW1ldGVy ICdyZXF1ZXN0JyBkZXNjcmlwdGlvbiBpbiAnaW50ZWxfbG9naWNhbF9yaW5nX2JlZ2luJwo+ICAg Li8vZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmM6NzgwOiB3YXJuaW5nOiBFeGNlc3Mg ZnVuY3Rpb24gcGFyYW1ldGVyICdjdHgnIGRlc2NyaXB0aW9uIGluICdpbnRlbF9sb2dpY2FsX3Jp bmdfYmVnaW4nCgpUaGlzIGlzIGFscmVhZHkgZml4ZWQgYnkKCmNvbW1pdCAzNzQ4ODdiYWU4NjFi ZTJlNjkxMzgxZjcwNGIzZDYwNjhhNTQ0NTdjCkF1dGhvcjogTWFzYW5hcmkgSWlkYSA8c3RhbmRi eTI0eDdAZ21haWwuY29tPgpEYXRlOiAgIFN1biBTZXAgMTMgMjE6MDg6MzEgMjAxNSArMDkwMAoK ICAgIGRybS9pOTE1OiBGaXggd2FybmluZ3Mgd2hpbGUgbWFrZSB4bWxkb2NzIGNhdXNlZCBieSBp bnRlbF9scmMuYwoKVGhhbmtzLApKYW5pLgoKCgo+Cj4gU2lnbmVkLW9mZi1ieTogR2VsaWFuZyBU YW5nIDxnZWxpYW5ndGFuZ0AxNjMuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9scmMuYyB8IDMgKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMiBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggNzJlMGVkZC4u OTYzOTkyYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTc2NSw4ICs3NjUs NyBAQCBzdGF0aWMgaW50IGxvZ2ljYWxfcmluZ19wcmVwYXJlKHN0cnVjdCBkcm1faTkxNV9nZW1f cmVxdWVzdCAqcmVxLCBpbnQgYnl0ZXMpCj4gIC8qKgo+ICAgKiBpbnRlbF9sb2dpY2FsX3Jpbmdf YmVnaW4oKSAtIHByZXBhcmUgdGhlIGxvZ2ljYWwgcmluZ2J1ZmZlciB0byBhY2NlcHQgc29tZSBj b21tYW5kcwo+ICAgKgo+IC0gKiBAcmVxdWVzdDogVGhlIHJlcXVlc3QgdG8gc3RhcnQgc29tZSBu ZXcgd29yayBmb3IKPiAtICogQGN0eDogTG9naWNhbCByaW5nIGNvbnRleHQgd2hvc2UgcmluZ2J1 ZmZlciBpcyBiZWluZyBwcmVwYXJlZC4KPiArICogQHJlcTogVGhlIHJlcXVlc3QgdG8gc3RhcnQg c29tZSBuZXcgd29yayBmb3IKPiAgICogQG51bV9kd29yZHM6IG51bWJlciBvZiBEV09SRHMgdGhh dCB3ZSBwbGFuIHRvIHdyaXRlIHRvIHRoZSByaW5nYnVmZmVyLgo+ICAgKgo+ICAgKiBUaGUgcmlu Z2J1ZmZlciBtaWdodCBub3QgYmUgcmVhZHkgdG8gYWNjZXB0IHRoZSBjb21tYW5kcyByaWdodCBh d2F5IChtYXliZSBpdCBuZWVkcyB0bwo+IC0tIAo+IDEuOS4xCj4KPgoKLS0gCkphbmkgTmlrdWxh LCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754204AbbIPOCF (ORCPT ); Wed, 16 Sep 2015 10:02:05 -0400 Received: from mga03.intel.com ([134.134.136.65]:15400 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753122AbbIPOCD (ORCPT ); Wed, 16 Sep 2015 10:02:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,539,1437462000"; d="scan'208";a="806423788" From: Jani Nikula To: Geliang Tang , Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in intel_lrc.c In-Reply-To: <8648ce6f3580053f73967453b119696c21622e05.1442347520.git.geliangtang@163.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <8648ce6f3580053f73967453b119696c21622e05.1442347520.git.geliangtang@163.com> User-Agent: Notmuch/0.20.2+58~g39779b9 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 16 Sep 2015 17:04:56 +0300 Message-ID: <87zj0mtq7r.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Sep 2015, Geliang Tang wrote: > Fix the following 'make htmldocs' warnings: > > .//drivers/gpu/drm/i915/intel_lrc.c:780: warning: No description found for parameter 'req' > .//drivers/gpu/drm/i915/intel_lrc.c:780: warning: Excess function parameter 'request' description in 'intel_logical_ring_begin' > .//drivers/gpu/drm/i915/intel_lrc.c:780: warning: Excess function parameter 'ctx' description in 'intel_logical_ring_begin' This is already fixed by commit 374887bae861be2e691381f704b3d6068a54457c Author: Masanari Iida Date: Sun Sep 13 21:08:31 2015 +0900 drm/i915: Fix warnings while make xmldocs caused by intel_lrc.c Thanks, Jani. > > Signed-off-by: Geliang Tang > --- > drivers/gpu/drm/i915/intel_lrc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c > index 72e0edd..963992a 100644 > --- a/drivers/gpu/drm/i915/intel_lrc.c > +++ b/drivers/gpu/drm/i915/intel_lrc.c > @@ -765,8 +765,7 @@ static int logical_ring_prepare(struct drm_i915_gem_request *req, int bytes) > /** > * intel_logical_ring_begin() - prepare the logical ringbuffer to accept some commands > * > - * @request: The request to start some new work for > - * @ctx: Logical ring context whose ringbuffer is being prepared. > + * @req: The request to start some new work for > * @num_dwords: number of DWORDs that we plan to write to the ringbuffer. > * > * The ringbuffer might not be ready to accept the commands right away (maybe it needs to > -- > 1.9.1 > > -- Jani Nikula, Intel Open Source Technology Center