From: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
To: Yuval Mintz <Yuval.Mintz@qlogic.com>
Cc: Michal Schmidt <mschmidt@redhat.com>,
David Miller <davem@davemloft.net>,
"LinoSanfilippo\@gmx.de" <LinoSanfilippo@gmx.de>,
Ariel Elior <Ariel.Elior@qlogic.com>,
netdev <netdev@vger.kernel.org>,
"cascardo\@cascardo.eti.br" <cascardo@cascardo.eti.br>,
"brking\@linux.vnet.ibm.com" <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH v4] bnx2x: Alloc 4k fragment for each rx ring buffer element
Date: Thu, 28 May 2015 10:26:43 -0300 [thread overview]
Message-ID: <87zj4osui4.fsf@sycorax.br.ibm.com> (raw)
In-Reply-To: <B5657A6538887040AD3A81F1008BEC63DA8E49@avmb3.qlogic.org> (Yuval Mintz's message of "Thu, 28 May 2015 07:24:22 +0000")
Yuval Mintz <Yuval.Mintz@qlogic.com> writes:
> Actually, this upsets me greatly. We didn't see it on a system with 4KB
> pages, but this means you've actually tried to 'sell' us a fastpath fix that
> was never tested on machines for which it was meant as an improvement.
The iteration that inserted this bug was such a quick fix that I didn`t
bother rerunning it. It just modified the type variable. Take my word
it was a one time honest mistake.
The last iteration, as well as all of the previous ones were tested on
Power servers with bnx2x adapters. The tests included stressing the
device and several iterations of hotplugging the adapter, helping us to
verify correctness of the rx queue operation as well as verifying that DMA
mapping/unmapping were correct.
--
Gabriel Krisman Bertazi
prev parent reply other threads:[~2015-05-28 13:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 20:45 [PATCH v2] bnx2x: Alloc 4k fragment for each rx ring buffer element Gabriel Krisman Bertazi
2015-04-24 23:24 ` Lino Sanfilippo
2015-04-29 13:30 ` Gabriel Krisman Bertazi
2015-04-30 11:25 ` Yuval Mintz
2015-04-30 20:05 ` David Miller
2015-05-04 19:32 ` [PATCH v3] " Gabriel Krisman Bertazi
2015-05-04 19:58 ` Yuval Mintz
2015-05-15 20:43 ` Gabriel Krisman Bertazi
2015-05-17 7:14 ` Yuval Mintz
2015-05-21 13:20 ` [PATCH v4] " Gabriel Krisman Bertazi
2015-05-23 10:04 ` Yuval Mintz
2015-05-23 11:14 ` Lino Sanfilippo
2015-05-27 8:59 ` Michal Schmidt
2015-05-27 16:51 ` [PATCH] " Gabriel Krisman Bertazi
2015-06-01 22:57 ` David Miller
2015-05-28 7:24 ` [PATCH v4] " Yuval Mintz
2015-05-28 13:26 ` Gabriel Krisman Bertazi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj4osui4.fsf@sycorax.br.ibm.com \
--to=krisman@linux.vnet.ibm.com \
--cc=Ariel.Elior@qlogic.com \
--cc=LinoSanfilippo@gmx.de \
--cc=Yuval.Mintz@qlogic.com \
--cc=brking@linux.vnet.ibm.com \
--cc=cascardo@cascardo.eti.br \
--cc=davem@davemloft.net \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.