All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Jones <drjones@redhat.com>,
	Julien Grall <julien.grall@linaro.org>,
	Keir Fraser <keir@xen.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Olaf Hering <olaf@aepfle.de>, Tim Deegan <tim@xen.org>,
	David Vrabel <david.vrabel@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v6 10/10] (lib)xl: soft reset support
Date: Fri, 22 May 2015 16:55:20 +0200	[thread overview]
Message-ID: <87zj4wu0fb.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <1431510585-12544-11-git-send-email-vkuznets@redhat.com> (Vitaly Kuznetsov's message of "Wed, 13 May 2015 11:49:45 +0200")

Vitaly Kuznetsov <vkuznets@redhat.com> writes:

> Perform soft reset when a domain did SHUTDOWN_soft_reset. Migrate the
> content with xc_domain_soft_reset(), reload dm and toolstack.
>

..skip..

> +void libxl__xc_domain_soft_reset(libxl__egc *egc,
> +                                 libxl__domain_create_state *dcs)
> +{
> +    STATE_AO_GC(dcs->ao);
> +    libxl_ctx *ctx = libxl__gc_owner(gc);
> +    const uint32_t domid_soft_reset = dcs->domid_soft_reset;
> +    const uint32_t domid = dcs->guest_domid;
> +    uint8_t *buf;
> +    uint32_t len;
> +    int rc;
> +    libxl__domain_suspend_state *dss;
> +
> +    GCNEW(dss);
> +    dss->ao = ao;
> +    dss->domid = domid_soft_reset;
> +
> +    rc = libxl__toolstack_save(domid_soft_reset, &buf, &len, dss);
> +    if (rc) goto out;

It turned out being too late, QEMU process for the original domain is
already dead at this point and xenstore in cleanen. Qemu-upstream will
fail when it requires e.g. video ram info. I'll move this call earlier
in the chain in v7.

..skip...

-- 
  Vitaly

      reply	other threads:[~2015-05-22 14:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  9:49 [PATCH v6 00/10] toolstack-based approach to pvhvm guest kexec Vitaly Kuznetsov
2015-05-13  9:49 ` [PATCH v6 01/10] xen: introduce SHUTDOWN_soft_reset shutdown reason Vitaly Kuznetsov
2015-05-13  9:49 ` [PATCH v6 02/10] libxl: support " Vitaly Kuznetsov
2015-05-20  9:44   ` Wei Liu
2015-05-13  9:49 ` [PATCH v6 03/10] xen: introduce DOMDYING_locked state Vitaly Kuznetsov
2015-05-13  9:49 ` [PATCH v6 04/10] xen: Introduce XENMEM_soft_reset operation Vitaly Kuznetsov
2015-05-22  9:38   ` Jan Beulich
2015-05-22 15:36     ` Vitaly Kuznetsov
2015-05-22 16:26       ` Jan Beulich
2015-05-25  9:24         ` Tim Deegan
2015-05-25 10:06           ` Vitaly Kuznetsov
2015-05-25 16:13             ` Tim Deegan
2015-05-26  8:05               ` Vitaly Kuznetsov
2015-05-26  8:50                 ` Jan Beulich
2015-05-13  9:49 ` [PATCH v6 05/10] xsm: add XENMEM_soft_reset support Vitaly Kuznetsov
2015-05-20 23:30   ` Daniel De Graaf
2015-05-21  9:49     ` Vitaly Kuznetsov
2015-05-21 14:25       ` Daniel De Graaf
2015-05-22  9:40   ` Jan Beulich
2015-05-22 14:58     ` Daniel De Graaf
2015-05-22 15:26       ` Jan Beulich
2015-05-22 14:59     ` Vitaly Kuznetsov
2015-05-13  9:49 ` [PATCH v6 06/10] libxc: support XENMEM_soft_reset operation Vitaly Kuznetsov
2015-05-13  9:49 ` [PATCH v6 07/10] libxc: introduce soft reset for HVM domains Vitaly Kuznetsov
2015-05-20 15:10   ` Julien Grall
2015-05-20 15:20     ` Vitaly Kuznetsov
2015-05-20 15:28       ` Julien Grall
2015-05-13  9:49 ` [PATCH v6 08/10] xl: introduce enum domain_restart_type Vitaly Kuznetsov
2015-05-13  9:49 ` [PATCH v6 09/10] libxc: add XC_DEVICE_MODEL_SAVE_FILE Vitaly Kuznetsov
2015-05-13  9:49 ` [PATCH v6 10/10] (lib)xl: soft reset support Vitaly Kuznetsov
2015-05-22 14:55   ` Vitaly Kuznetsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj4wu0fb.fsf@vitty.brq.redhat.com \
    --to=vkuznets@redhat.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=drjones@redhat.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@linaro.org \
    --cc=keir@xen.org \
    --cc=olaf@aepfle.de \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.