From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqKkB-0002vi-O8 for qemu-devel@nongnu.org; Thu, 07 May 2015 08:17:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqKk8-0008PW-DZ for qemu-devel@nongnu.org; Thu, 07 May 2015 08:17:35 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:45287 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqKk8-0008PG-7e for qemu-devel@nongnu.org; Thu, 07 May 2015 08:17:32 -0400 References: <1430990964-10528-1-git-send-email-zhaoshenglong@huawei.com> <1430990964-10528-5-git-send-email-zhaoshenglong@huawei.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1430990964-10528-5-git-send-email-zhaoshenglong@huawei.com> Date: Thu, 07 May 2015 13:18:15 +0100 Message-ID: <87zj5gd1iw.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v6 04/22] hw/acpi/aml-build: Add aml_memory32_fixed() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, imammedo@redhat.com, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org Shannon Zhao writes: > From: Shannon Zhao > > Add aml_memory32_fixed() for describing device mmio region in resource template. > These can be used to generating DSDT table for ACPI on ARM. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée > --- > hw/acpi/aml-build.c | 27 +++++++++++++++++++++++++++ > include/hw/acpi/aml-build.h | 2 ++ > 2 files changed, 29 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 8d01959..61407b7 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -26,6 +26,7 @@ > #include > #include "hw/acpi/aml-build.h" > #include "qemu/bswap.h" > +#include "qemu/bitops.h" > #include "hw/acpi/bios-linker-loader.h" > > static GArray *build_alloc_array(void) > @@ -505,6 +506,32 @@ Aml *aml_call4(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml *arg4) > return var; > } > > +/* > + * ACPI 1.0: 6.4.3.4 Memory32Fixed (Memory Resource Descriptor Macro) > + */ > +Aml *aml_memory32_fixed(uint32_t addr, uint32_t size, > + AmlReadAndWrite read_and_write) > +{ > + Aml *var = aml_alloc(); > + build_append_byte(var->buf, 0x86); /* Memory32Fixed Resource Descriptor */ > + build_append_byte(var->buf, 9); /* Length, bits[7:0] value = 9 */ > + build_append_byte(var->buf, 0); /* Length, bits[15:8] value = 0 */ > + build_append_byte(var->buf, read_and_write); /* Write status, 1 rw 0 ro */ > + > + /* Range base address */ > + build_append_byte(var->buf, extract32(addr, 0, 8)); /* bits[7:0] */ > + build_append_byte(var->buf, extract32(addr, 8, 8)); /* bits[15:8] */ > + build_append_byte(var->buf, extract32(addr, 16, 8)); /* bits[23:16] */ > + build_append_byte(var->buf, extract32(addr, 24, 8)); /* bits[31:24] */ > + > + /* Range length */ > + build_append_byte(var->buf, extract32(size, 0, 8)); /* bits[7:0] */ > + build_append_byte(var->buf, extract32(size, 8, 8)); /* bits[15:8] */ > + build_append_byte(var->buf, extract32(size, 16, 8)); /* bits[23:16] */ > + build_append_byte(var->buf, extract32(size, 24, 8)); /* bits[31:24] */ > + return var; > +} > + > /* ACPI 1.0b: 6.4.2.5 I/O Port Descriptor */ > Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base, > uint8_t aln, uint8_t len) > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 1705001..154823b 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -162,6 +162,8 @@ Aml *aml_call1(const char *method, Aml *arg1); > Aml *aml_call2(const char *method, Aml *arg1, Aml *arg2); > Aml *aml_call3(const char *method, Aml *arg1, Aml *arg2, Aml *arg3); > Aml *aml_call4(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml *arg4); > +Aml *aml_memory32_fixed(uint32_t addr, uint32_t size, > + AmlReadAndWrite read_and_write); > Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base, > uint8_t aln, uint8_t len); > Aml *aml_operation_region(const char *name, AmlRegionSpace rs, -- Alex Bennée