From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Document that mmap forwarding is discouraged Date: Thu, 16 Oct 2014 13:48:20 +0300 Message-ID: <87zjcwcmtn.fsf@intel.com> References: <1413455298-1120-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 953AE6E193 for ; Thu, 16 Oct 2014 03:48:42 -0700 (PDT) In-Reply-To: <1413455298-1120-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel Graphics Development Cc: Daniel Vetter , David Herrmann List-Id: intel-gfx@lists.freedesktop.org On Thu, 16 Oct 2014, Daniel Vetter wrote: > Too many new drm driver writers seem to look at i915 for inspiration. > But we have two ways to do mmap, so discourage readers from the old, > ugly version. In a new driver we'd just expose two mmap offsets per > object, one for the gtt map and the other for the cpu map. > > Cc: "Cheng, Yao" > Cc: David Herrmann > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_gem.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index e9c783d55612..09d859b89aac 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -1466,6 +1466,15 @@ unlock: > * > * While the mapping holds a reference on the contents of the object, it doesn't > * imply a ref on the object itself. > + * > + * IMPORTANT: > + * > + * DRM driver writers who look a this function as an example for how to do GEM > + * mmap support, please don't implement mmap support like here. The modern way > + * to implement DRM mmap support is with an mmap offset ioctl (like > + * i915_gem_mmap_gtt) and then using the mmap syscall on the DRM fd directly. > + * That way debug tooling like valgrind will understand what's going on, hiding > + * the mmap call in a driver private ioctl will break that. Maybe a sentence here about why we're doing things differently, instead of merely "do as I say, don't do as I do"? It smells like hysterical raisins, but no harm in spelling it out, right? BR, Jani. > */ > int > i915_gem_mmap_ioctl(struct drm_device *dev, void *data, > -- > 1.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center