From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39577)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1XEgzZ-0002gw-QK
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:49:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1XEgzT-0001qe-Km
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:49:37 -0400
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:49251 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1XEgzT-0001qV-EI
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:49:31 -0400
References: <1406879176-4008-1-git-send-email-arei.gonglei@huawei.com>
	<1406879176-4008-2-git-send-email-arei.gonglei@huawei.com>
	<53DBB9D8.50707@redhat.com>
	<33183CC9F5247A488A2544077AF1902086C23B6A@SZXEMA503-MBS.china.huawei.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
Date: Tue, 05 Aug 2014 16:48:18 +0100
In-reply-to: <33183CC9F5247A488A2544077AF1902086C23B6A@SZXEMA503-MBS.china.huawei.com>
Message-ID: <87zjfjj5s8.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 1/8] CODING_STYLE: Section about
	conditional statement
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>, "peter.crosthwaite@xilinx.com" <peter.crosthwaite@xilinx.com>, "Huangweidong (C)" <weidong.huang@huawei.com>, "aliguori@amazon.com" <aliguori@amazon.com>, "mst@redhat.com" <mst@redhat.com>, "marcel.a@redhat.com" <marcel.a@redhat.com>, Luonengjun <luonengjun@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "armbru@redhat.com" <armbru@redhat.com>, "av1474@comtv.ru" <av1474@comtv.ru>, "kraxel@redhat.com" <kraxel@redhat.com>, "stefanha@redhat.com" <stefanha@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "dmitry@daynix.com" <dmitry@daynix.com>, "imammedo@redhat.com" <imammedo@redhat.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "afaerber@suse.de" <afaerber@suse.de>, "dgilbert@redhat.com" <dgilbert@redhat.com>


Gonglei (Arei) writes:

> Hi,
>
>> > Yoda conditions lack readability, and QEMU has a
>> > strict compiler configuration for checking a common
>> > mistake like "if (dev = NULL)". Make it a written rule.
<snip>
>> 
>> I know this is my suggested text, but now that I'm re-reading it, I'd
>> recommend s/0/1/ in all three places, since comparison to 0 is one of
>> those special cases where '!a' is faster to write than 'a == 0'.
>> 
> Got it.

Should we add explicit examples for:

if (x)
if (!x)

then?

-- 
Alex Bennée