From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Date: Tue, 06 May 2014 14:24:28 +0000 Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr Message-Id: <87zjivq9mb.fsf@linux.vnet.ibm.com> List-Id: References: <1399224075-18041-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <536773C2.1070502@suse.de> <20140506004133.GA12595@iris.ozlabs.ibm.com> <536887EF.2070201@suse.de> In-Reply-To: <536887EF.2070201@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf , Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org Alexander Graf writes: > On 06.05.14 02:41, Paul Mackerras wrote: >> On Mon, May 05, 2014 at 01:19:30PM +0200, Alexander Graf wrote: >>> On 05/04/2014 07:21 PM, Aneesh Kumar K.V wrote: >>>> +#ifdef CONFIG_PPC_BOOK3S_64 >>>> + return vcpu->arch.fault_dar; >>> How about PA6T and G5s? >> G5 sets DAR on an alignment interrupt. >> >> As for PA6T, I don't know for sure, but if it doesn't, ordinary >> alignment interrupts wouldn't be handled properly, since the code in >> arch/powerpc/kernel/align.c assumes DAR contains the address being >> accessed on all PowerPC CPUs. > > Now that's a good point. If we simply behave like Linux, I'm fine. This > definitely deserves a comment on the #ifdef in the code. How about ? #ifdef CONFIG_PPC_BOOK3S_64 /* * Linux always expect a valid dar as per alignment * interrupt handling code (fix_alignment()). Don't compute the dar * value here, instead used the saved dar value. Right now we restrict * this only for BOOK3S-64. */ return vcpu->arch.fault_dar; #else -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp04.in.ibm.com (e28smtp04.in.ibm.com [122.248.162.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AC6301412D7 for ; Wed, 7 May 2014 00:12:37 +1000 (EST) Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 May 2014 19:42:33 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id C0343125804D for ; Tue, 6 May 2014 19:41:26 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s46ECZR87799124 for ; Tue, 6 May 2014 19:42:35 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s46ECSGS015350 for ; Tue, 6 May 2014 19:42:29 +0530 From: "Aneesh Kumar K.V" To: Alexander Graf , Paul Mackerras Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr In-Reply-To: <536887EF.2070201@suse.de> References: <1399224075-18041-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <536773C2.1070502@suse.de> <20140506004133.GA12595@iris.ozlabs.ibm.com> <536887EF.2070201@suse.de> Date: Tue, 06 May 2014 19:42:28 +0530 Message-ID: <87zjivq9mb.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Alexander Graf writes: > On 06.05.14 02:41, Paul Mackerras wrote: >> On Mon, May 05, 2014 at 01:19:30PM +0200, Alexander Graf wrote: >>> On 05/04/2014 07:21 PM, Aneesh Kumar K.V wrote: >>>> +#ifdef CONFIG_PPC_BOOK3S_64 >>>> + return vcpu->arch.fault_dar; >>> How about PA6T and G5s? >> G5 sets DAR on an alignment interrupt. >> >> As for PA6T, I don't know for sure, but if it doesn't, ordinary >> alignment interrupts wouldn't be handled properly, since the code in >> arch/powerpc/kernel/align.c assumes DAR contains the address being >> accessed on all PowerPC CPUs. > > Now that's a good point. If we simply behave like Linux, I'm fine. This > definitely deserves a comment on the #ifdef in the code. How about ? #ifdef CONFIG_PPC_BOOK3S_64 /* * Linux always expect a valid dar as per alignment * interrupt handling code (fix_alignment()). Don't compute the dar * value here, instead used the saved dar value. Right now we restrict * this only for BOOK3S-64. */ return vcpu->arch.fault_dar; #else -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr Date: Tue, 06 May 2014 19:42:28 +0530 Message-ID: <87zjivq9mb.fsf@linux.vnet.ibm.com> References: <1399224075-18041-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <536773C2.1070502@suse.de> <20140506004133.GA12595@iris.ozlabs.ibm.com> <536887EF.2070201@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Alexander Graf , Paul Mackerras Return-path: In-Reply-To: <536887EF.2070201@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org QWxleGFuZGVyIEdyYWYgPGFncmFmQHN1c2UuZGU+IHdyaXRlczoKCj4gT24gMDYuMDUuMTQgMDI6 NDEsIFBhdWwgTWFja2VycmFzIHdyb3RlOgo+PiBPbiBNb24sIE1heSAwNSwgMjAxNCBhdCAwMTox OTozMFBNICswMjAwLCBBbGV4YW5kZXIgR3JhZiB3cm90ZToKPj4+IE9uIDA1LzA0LzIwMTQgMDc6 MjEgUE0sIEFuZWVzaCBLdW1hciBLLlYgd3JvdGU6Cj4+Pj4gKyNpZmRlZiBDT05GSUdfUFBDX0JP T0szU182NAo+Pj4+ICsJcmV0dXJuIHZjcHUtPmFyY2guZmF1bHRfZGFyOwo+Pj4gSG93IGFib3V0 IFBBNlQgYW5kIEc1cz8KPj4gRzUgc2V0cyBEQVIgb24gYW4gYWxpZ25tZW50IGludGVycnVwdC4K Pj4KPj4gQXMgZm9yIFBBNlQsIEkgZG9uJ3Qga25vdyBmb3Igc3VyZSwgYnV0IGlmIGl0IGRvZXNu J3QsIG9yZGluYXJ5Cj4+IGFsaWdubWVudCBpbnRlcnJ1cHRzIHdvdWxkbid0IGJlIGhhbmRsZWQg cHJvcGVybHksIHNpbmNlIHRoZSBjb2RlIGluCj4+IGFyY2gvcG93ZXJwYy9rZXJuZWwvYWxpZ24u YyBhc3N1bWVzIERBUiBjb250YWlucyB0aGUgYWRkcmVzcyBiZWluZwo+PiBhY2Nlc3NlZCBvbiBh bGwgUG93ZXJQQyBDUFVzLgo+Cj4gTm93IHRoYXQncyBhIGdvb2QgcG9pbnQuIElmIHdlIHNpbXBs eSBiZWhhdmUgbGlrZSBMaW51eCwgSSdtIGZpbmUuIFRoaXMgCj4gZGVmaW5pdGVseSBkZXNlcnZl cyBhIGNvbW1lbnQgb24gdGhlICNpZmRlZiBpbiB0aGUgY29kZS4KCgpIb3cgYWJvdXQgPwoKI2lm ZGVmIENPTkZJR19QUENfQk9PSzNTXzY0CgkvKgoJICogTGludXggYWx3YXlzIGV4cGVjdCBhIHZh bGlkICBkYXIgYXMgcGVyIGFsaWdubWVudAoJICogaW50ZXJydXB0IGhhbmRsaW5nIGNvZGUgKGZp eF9hbGlnbm1lbnQoKSkuIERvbid0IGNvbXB1dGUgdGhlIGRhcgoJICogdmFsdWUgaGVyZSwgaW5z dGVhZCB1c2VkIHRoZSBzYXZlZCBkYXIgdmFsdWUuIFJpZ2h0IG5vdyB3ZSByZXN0cmljdAoJICog dGhpcyBvbmx5IGZvciBCT09LM1MtNjQuCgkgKi8KCXJldHVybiB2Y3B1LT5hcmNoLmZhdWx0X2Rh cjsKI2Vsc2UKCgotYW5lZXNoCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0cy5v emxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY=