From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [RFC] drm/i915: Clean up display pipe register
	accesses
Date: Thu, 31 Oct 2013 14:30:34 +0200
Message-ID: <87zjpppqqd.fsf@intel.com>
References: <1383141129-3119-1-git-send-email-antti.koskipaa@linux.intel.com>
	<8738nhevz2.fsf@intel.com> <527236AE.5020604@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id F0C07EFCF8
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 31 Oct 2013 05:33:45 -0700 (PDT)
In-Reply-To: <527236AE.5020604@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Antti =?utf-8?B?S29za2lww6TDpA==?= <antti.koskipaa@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAzMSBPY3QgMjAxMywgQW50dGkgS29za2lww6TDpCA8YW50dGkua29za2lwYWFAbGlu
dXguaW50ZWwuY29tPiB3cm90ZToKPiBPbiAxMC8zMS8xMyAwOTozMiwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4+IE9uIFdlZCwgMzAgT2N0IDIwMTMsIEFudHRpIEtvc2tpcGFhIDxhbnR0aS5rb3NraXBh
YUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Pj4gVXBjb21pbmcgaGFyZHdhcmUgd2lsbCBub3Qg
aGF2ZSB0aGUgdmFyaW91cyBkaXNwbGF5IHBpcGUgcmVnaXN0ZXIKPj4+IHJhbmdlcyBldmVubHkg
c3BhY2VkIGluIG1lbW9yeS4gQ2hhbmdlIHJlZ2lzdGVyIGFkZHJlc3MgY2FsY3VsYXRpb25zCj4+
PiBpbnRvIGFycmF5IGxvb2t1cHMuCj4+Pgo+Pj4gVGVzdGVkIG9uIFNhbmR5QnJpZGdlLgo+Pj4K
Pj4+IEkgbGVmdCB0aGUgVU1TIGNydWZ0IHVudG91Y2hlZC4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5
OiBBbnR0aSBLb3NraXBhYSA8YW50dGkua29za2lwYWFAbGludXguaW50ZWwuY29tPgo+Pj4gLS0t
Cj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZHZvX25zMjUwMS5jIHwgIDYgKystLQo+Pj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMgICB8IDE2ICsrKysrKysrKysrCj4+PiAgZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgIHwgMTAgKysrKysrLQo+Pj4gIGRyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICB8IDU5ICsrKysrKysrKysrKysrKysrKysrKysrKysr
Ky0tLS0tLS0tLS0tLQo+Pj4gIDQgZmlsZXMgY2hhbmdlZCwgNjkgaW5zZXJ0aW9ucygrKSwgMjIg
ZGVsZXRpb25zKC0pCj4+IAo+PiBbc25pcF0KPj4gCj4+PiArLyogUGlwZSB0aW1pbmcgcmVncyAq
Lwo+Pj4gKyNkZWZpbmUgSFRPVEFMKHRyYW5zKSAoZGV2X3ByaXYtPnRyYW5zX29mZnNldHNbdHJh
bnNdKQo+Pj4gKyNkZWZpbmUgSEJMQU5LKHRyYW5zKSAoZGV2X3ByaXYtPnRyYW5zX29mZnNldHNb
dHJhbnNdICsgMHgwNCkKPj4+ICsjZGVmaW5lIEhTWU5DKHRyYW5zKSAoZGV2X3ByaXYtPnRyYW5z
X29mZnNldHNbdHJhbnNdICsgMHgwOCkKPj4+ICsjZGVmaW5lIFZUT1RBTCh0cmFucykgKGRldl9w
cml2LT50cmFuc19vZmZzZXRzW3RyYW5zXSArIDB4MGMpCj4+PiArI2RlZmluZSBWQkxBTksodHJh
bnMpIChkZXZfcHJpdi0+dHJhbnNfb2Zmc2V0c1t0cmFuc10gKyAweDEwKQo+Pj4gKyNkZWZpbmUg
VlNZTkModHJhbnMpIChkZXZfcHJpdi0+dHJhbnNfb2Zmc2V0c1t0cmFuc10gKyAweDE0KQo+Pj4g
KyNkZWZpbmUgQkNMUlBBVCh0cmFucykgKGRldl9wcml2LT50cmFuc19vZmZzZXRzW3RyYW5zXSAr
IDB4MjApCj4+PiArI2RlZmluZSBWU1lOQ1NISUZUKHRyYW5zKSAoZGV2X3ByaXYtPnRyYW5zX29m
ZnNldHNbdHJhbnNdICsgMHgyOCkKPj4+ICsjZGVmaW5lIFBJUEVTUkMocGlwZSkgKGRldl9wcml2
LT50cmFuc19vZmZzZXRzW3BpcGVdICsgMHgxYykKPj4gCj4+IFRoaXMgaXMgdGhlIHBhcnQgdGhh
dCBnaXZlcyBtZSB0aGUgY3JlZXBzIGFib3V0IHRoaXMgYXBwcm9hY2gsIGluIG1hbnkKPj4gZGlm
ZmVyZW50IHdheXMuIEZpcnN0LCBJIGRvbid0IGtub3cgaWYgd2UgaGF2ZSBndWFyYW50ZWVzIHRo
YXQgdGhlCj4+IG9mZnNldHMgYmV0d2VlbiByZWdpc3RlcnMgcmVtYWluIHRoZSBzYW1lOyBtYXli
ZSB0aGV5IGRvLCBtYXliZSB0aGV5Cj4+IGRvbid0Lgo+Cj4gUHJvYmFibHkgdGhleSBkbywgc2lu
Y2UgaXQncyB1c3VhbGx5IHRoZSBzYW1lIElQIGJsb2NrIHRoYXQncyBqdXN0Cj4gcmVwbGljYXRl
ZCBuIHRpbWVzLgo+Cj4+IFNlY29uZCwgSSBmaW5kIG15c2VsZiBzZWFyY2hpbmcgZm9yIHRoZSBy
ZWdpc3RlciBhZGRyZXNzZXMgaW4KPj4gdGhpcyBmaWxlIHF1aXRlIG9mdGVuLiBXaXRoIHRoaXMg
dGhlICJyZXZlcnNlIGxvb2t1cCIgYmVjb21lcwo+PiBoYXJkLgo+Cj4gV2h5IGRvIHlvdSBzZWFy
Y2ggYnkgYWRkcmVzcz8gVGhlIHJlZ2lzdGVycyBoYXZlIG5hbWVzLgoKQmVjYXVzZSB0aGUgbmFt
ZXMgaW4gdGhlIHNwZWNzIGFyZSBhcyB2b2xhdGlsZSBhcyBldmVyeXRoaW5nIGVsc2UgZnJvbQpn
ZW5lcmF0aW9uIHRvIGdlbmVyYXRpb24uLi4gQW5kIHdoZW4geW91IG5lZWQgdG8gYWRkIGEgbmV3
ICNkZWZpbmUsCnBvc3NpYmx5IGZyb20gYSBzcGVjIHdpdGggdGhlIG5ldyBjb29sIG5hbWUgZm9y
IHRoZSB0aGluZywgSSBsaWtlIHRvCmNoZWNrIGlmIGl0J3MgYWxyZWFkeSB0aGVyZSwgaGlkaW5n
LiA6KQoKQWxzbywgaXQncyBqdXN0IHNsb3dlciB0byBjaGVjayB3aGljaCBleGFjdCByZWdpc3Rl
ciBhbnkgcmVhZCBvciB3cml0ZQplbmRzIHVwIHVzaW5nIGlmIHlvdSBoYXZlIHRvIGdvIHRocm91
Z2ggdGhlIHRhYmxlLiBNYXliZSBpdCdzIGp1c3QgbWUKcnVubmluZyBjb2RlIGluIG15IGhlYWQg
aW4gcGVkYW50aWMgbW9kZSB0aGF0IHRoaXMgYWZmZWN0cy4gKnNocnVnKi4KCj4gQW5kIGJlY2F1
c2UgdGhlIFVNUyBzdHVmZiBoYWQgdG8gYmUgbGVmdCBpbiwgdGhlIG9yaWdpbmFsIGRlZmluaXRp
b25zCj4gdy9hZGRyZXNzZXMgYXJlIHN0aWxsIHRoZXJlLgo+Cj4+IFRoaXJkLCBhbiB1bnN1YnN0
YW5jaWF0ZWQgY2xhaW0sIGl0IGp1c3QgKmZlZWxzKiBsaWtlIHRvbyBtYW55Cj4+IGxldmVscyBv
ZiBpbmRpcmVjdGlvbiB0byBiZSBjb21mb3J0YWJsZS4KPgo+IFNlZSBiZWxvdyBmb3Igc3RhY2sg
dXNhZ2Ugb2YgeW91ciBhcHByb2FjaC4KPgo+PiBIZXJlJ3MgYW4gYWx0ZXJuYXRpdmUgYXBwcm9h
Y2guIEhvdyBhYm91dCB3ZSBjaGFuZ2UgdGhlIGRlZmluZXMgZm9yCj4+IF9QSVBFKCksIF9UUkFO
U0NPREVSKCksIGV0Yy4gdG8gcmVxdWlyZSB0aGUgdGhlIHJlZ2lzdGVyIGFkZHJlc3NlcyBmb3IK
Pj4gKmV2ZXJ5KiBwaXBlLCB0cmFuc2NvZGVyLCBldGMuIGFzIHBhcmFtZXRlcnMuIEl0IG1heSBi
ZSBhIGJpdCB0ZWRpb3VzIHRvCj4+IGNoYW5nZSBhbGwgdXNlcyBvZiB0aGUgbWFjcm9zLCBidXQg
YXQgbGVhc3QgaXQncyBzdHJhaWdodGZvcndhcmQsIHdpdGgsCj4KPiBXaGF0IGRvIHlvdSBtZWFu
ICJjaGFuZ2UgYWxsIHRoZSB1c2VzIG9mIHRoZSBtYWNyb3MiPyBOb2JvZHkgdXNlcyBfUElQRQo+
IGFuZCBfVFJBTlNDT0RFUiBkaXJlY3RseS4gSWYgdGhleSBkaWQsIHdlJ2QgaGF2ZSB0byBjaGFu
Z2UgdGhlbSAqZXZlcnkKPiB0aW1lKiB3ZSBhZGRlZCBhIGRpc3BsYXkgcGlwZSwgdGh1cyBuZWdh
dGluZyB0aGUgd2hvbGUgcHVycG9zZSBvZiB0aGlzCj4gcGF0Y2guCgpBbGwgdXNlcyBvZiB0aGUg
bWFjcm9zIGluIGk5MTVfcmVnLmguCgo+PiBJIHRoaW5rLCBmZXdlciBjaGFuY2VzIGZvciBidWdz
Lgo+PiAKPj4gSGVyZSdzIGFuIGlkZWEgaG93IHRvIGRvIGl0IG5lYXRseToKPj4gCj4+ICNkZWZp
bmUgX09GRlNFVChpbmRleCwgLi4uKSAoKChpbnRbXSl7IF9fVkFfQVJHU19fIH0pW2luZGV4XSkK
Pj4gCj4+ICNkZWZpbmUgX1BJUEUocGlwZSwgYSwgYiwgYykJCQlfT0ZGU0VUKHBpcGUsIGEsIGIs
IGMpCj4+ICNkZWZpbmUgX1RSQU5TQ09ERVIodHJhbnMsIGEsIGIsIGMsIGVkcCkJX09GRlNFVCh0
cmFucywgYSwgYiwgYywgZWRwKQo+Cj4gVGhpcyBoZWxwcyB3aXRoIHlvdXIgZ3JlcHBpbmcgZm9y
IGFkZHJlc3NlcywgYnV0IGl0IGp1c3QgaGlkZXMgdGhlIGFycmF5Cj4gb24gdGhlIGxvY2FsIHZh
cmlhYmxlIHN0b3JhZ2UgYXJlYSBvbiB0aGUgc3RhY2ssIHJlcGxpY2F0ZWQgaW4gdGhlCj4gbWFj
aGluZSBjb2RlIGFzIG1hbnkgdGltZXMgYXMgdGhlcmUgYXJlIGZ1bmN0aW9ucyB0aGF0IGNhbGwg
dGhlc2UgbWFjcm9zLgo+Cj4+IEkgZGlkIG5vdCBsb29rIGF0IHRoZSBhc3NlbWJseSBwcm9kdWNl
ZCBieSB0aGF0IHZzLiB0aGUgdGFibGUgbG9va3VwLgo+Cj4gSSBkaWQsIGZvciBfVFJBTlNDT0RF
UigpIGFib3ZlOgo+Cj4gICAgIG1vdiAgICAgRFdPUkQgUFRSIFtyc3AtMjRdLCAweDYwMDAwCj4g
ICAgIG1vdiAgICAgRFdPUkQgUFRSIFtyc3AtMjBdLCAweDYxMDAwCj4gICAgIG1vdiAgICAgRFdP
UkQgUFRSIFtyc3AtMTZdLCAweDYzMDAwCj4gICAgIG1vdiAgICAgRFdPUkQgUFRSIFtyc3AtMTJd
LCAweDZmMDAwCj4gICAgIG1vdiAgICAgZWF4LCBEV09SRCBQVFIgW3JzcC0yNCtyZGkqNF0KClll
YWgsIG5vdCB0aGF0IGdyZWF0IEkgZ3Vlc3MuIEJ1dCB0aGF0J3MgcHJvYmFibHkgYWJvdXQgYXMg
Z29vZCBhcyBpdApnZXRzIHdpdGggdGhlIGFwcHJvYWNoIG9mIHBhc3NpbmcgYWxsIGFsdGVybmF0
aXZlcyB0byBfUElQRSgpIGFuZApfVFJBTlNDT0RFUigpLgoKQW55b25lIGVsc2UgaGF2ZSBvdGhl
ciBhbHRlcm5hdGl2ZXM/CgpCUiwKSmFuaS4KCgoKPgo+PiAKPj4gQlIsCj4+IEphbmkuCj4+IAo+
PiAKPj4gUFMuIEFuZCBkb24ndCBqdXN0IGdvIGFoZWFkIGFuZCBkbyB3aGF0IEkgc3VnZ2VzdGVk
OyBtb3JlIGJpa2VzaGVkZGluZwo+PiBtaWdodCBiZSByZXF1aXJlZCEgOykKPj4gCj4+IAo+Pj4g
Kwo+Pj4gKwo+Pj4gIC8qIFBpcGUgQSB0aW1pbmcgcmVncyAqLwo+Pj4gICNkZWZpbmUgX0hUT1RB
TF9BCShkZXZfcHJpdi0+aW5mby0+ZGlzcGxheV9tbWlvX29mZnNldCArIDB4NjAwMDApCj4+PiAg
I2RlZmluZSBfSEJMQU5LX0EJKGRldl9wcml2LT5pbmZvLT5kaXNwbGF5X21taW9fb2Zmc2V0ICsg
MHg2MDAwNCkKPj4+IEBAIC0xOTQxLDE1ICsxOTY5LDYgQEAKPj4+ICAjZGVmaW5lIF9CQ0xSUEFU
X0IJKGRldl9wcml2LT5pbmZvLT5kaXNwbGF5X21taW9fb2Zmc2V0ICsgMHg2MTAyMCkKPj4+ICAj
ZGVmaW5lIF9WU1lOQ1NISUZUX0IJKGRldl9wcml2LT5pbmZvLT5kaXNwbGF5X21taW9fb2Zmc2V0
ICsgMHg2MTAyOCkKPj4+ICAKPj4+IC0jZGVmaW5lIEhUT1RBTCh0cmFucykgX1RSQU5TQ09ERVIo
dHJhbnMsIF9IVE9UQUxfQSwgX0hUT1RBTF9CKQo+Pj4gLSNkZWZpbmUgSEJMQU5LKHRyYW5zKSBf
VFJBTlNDT0RFUih0cmFucywgX0hCTEFOS19BLCBfSEJMQU5LX0IpCj4+PiAtI2RlZmluZSBIU1lO
Qyh0cmFucykgX1RSQU5TQ09ERVIodHJhbnMsIF9IU1lOQ19BLCBfSFNZTkNfQikKPj4+IC0jZGVm
aW5lIFZUT1RBTCh0cmFucykgX1RSQU5TQ09ERVIodHJhbnMsIF9WVE9UQUxfQSwgX1ZUT1RBTF9C
KQo+Pj4gLSNkZWZpbmUgVkJMQU5LKHRyYW5zKSBfVFJBTlNDT0RFUih0cmFucywgX1ZCTEFOS19B
LCBfVkJMQU5LX0IpCj4+PiAtI2RlZmluZSBWU1lOQyh0cmFucykgX1RSQU5TQ09ERVIodHJhbnMs
IF9WU1lOQ19BLCBfVlNZTkNfQikKPj4+IC0jZGVmaW5lIEJDTFJQQVQocGlwZSkgX1BJUEUocGlw
ZSwgX0JDTFJQQVRfQSwgX0JDTFJQQVRfQikKPj4+IC0jZGVmaW5lIFZTWU5DU0hJRlQodHJhbnMp
IF9UUkFOU0NPREVSKHRyYW5zLCBfVlNZTkNTSElGVF9BLCBfVlNZTkNTSElGVF9CKQo+Pj4gLQo+
Pj4gIC8qIEhTVyBlRFAgUFNSIHJlZ2lzdGVycyAqLwo+Pj4gICNkZWZpbmUgRURQX1BTUl9CQVNF
KGRldikJCQkweDY0ODAwCj4+PiAgI2RlZmluZSBFRFBfUFNSX0NUTChkZXYpCQkJKEVEUF9QU1Jf
QkFTRShkZXYpICsgMCkKPj4+IEBAIC0zMjExLDEyICszMjMwLDE2IEBACj4+PiAgI2RlZmluZSAg
IFBJUEVfVkJMQU5LX0lOVEVSUlVQVF9TVEFUVVMJCSgxVUw8PDEpCj4+PiAgI2RlZmluZSAgIFBJ
UEVfT1ZFUkxBWV9VUERBVEVEX1NUQVRVUwkJKDFVTDw8MCkKPj4+ICAKPj4+IC0jZGVmaW5lIFBJ
UEVTUkMocGlwZSkgX1BJUEUocGlwZSwgX1BJUEVBU1JDLCBfUElQRUJTUkMpCj4+PiAtI2RlZmlu
ZSBQSVBFQ09ORih0cmFuKSBfVFJBTlNDT0RFUih0cmFuLCBfUElQRUFDT05GLCBfUElQRUJDT05G
KQo+Pj4gLSNkZWZpbmUgUElQRURTTChwaXBlKSAgX1BJUEUocGlwZSwgX1BJUEVBRFNMLCBfUElQ
RUJEU0wpCj4+PiAtI2RlZmluZSBQSVBFRlJBTUUocGlwZSkgX1BJUEUocGlwZSwgX1BJUEVBRlJB
TUVISUdILCBfUElQRUJGUkFNRUhJR0gpCj4+PiAtI2RlZmluZSBQSVBFRlJBTUVQSVhFTChwaXBl
KSAgX1BJUEUocGlwZSwgX1BJUEVBRlJBTUVQSVhFTCwgX1BJUEVCRlJBTUVQSVhFTCkKPj4+IC0j
ZGVmaW5lIFBJUEVTVEFUKHBpcGUpIF9QSVBFKHBpcGUsIF9QSVBFQVNUQVQsIF9QSVBFQlNUQVQp
Cj4+PiArI2RlZmluZSBQSVBFX0FfT0ZGU0VUCTB4NzAwMDAKPj4+ICsjZGVmaW5lIFBJUEVfQl9P
RkZTRVQJMHg3MTAwMAo+Pj4gKyNkZWZpbmUgUElQRV9FRFBfT0ZGU0VUCTB4N2YwMDAKPj4+ICsK
Pj4+ICsjZGVmaW5lIFBJUEVEU0wocGlwZSkgKGRldl9wcml2LT5waXBlX29mZnNldHNbcGlwZV0p
Cj4+PiArI2RlZmluZSBQSVBFQ09ORih0cmFuKSAoKGludCkodHJhbikgPT0gVFJBTlNDT0RFUl9F
RFAgPyBQSVBFX0VEUF9PRkZTRVQgOiBcCj4+PiArCQkJZGV2X3ByaXYtPnBpcGVfb2Zmc2V0c1t0
cmFuXSArIDB4MDgpCj4+PiArI2RlZmluZSBQSVBFU1RBVChwaXBlKSAoZGV2X3ByaXYtPnBpcGVf
b2Zmc2V0c1twaXBlXSArIDB4MjQpCj4+PiArI2RlZmluZSBQSVBFRlJBTUUocGlwZSkgKGRldl9w
cml2LT5waXBlX29mZnNldHNbcGlwZV0gKyAweDQwKQo+Pj4gKyNkZWZpbmUgUElQRUZSQU1FUElY
RUwocGlwZSkgKGRldl9wcml2LT5waXBlX29mZnNldHNbcGlwZV0gKyAweDQ0KQo+Pj4gIAo+Pj4g
ICNkZWZpbmUgVkxWX0RQRkxJUFNUQVQJCQkJKFZMVl9ESVNQTEFZX0JBU0UgKyAweDcwMDI4KQo+
Pj4gICNkZWZpbmUgICBQSVBFQl9MSU5FX0NPTVBBUkVfSU5UX0VOCQkoMTw8MjkpCj4+PiAtLSAK
Pj4+IDEuOC4xLjUKPj4+Cj4+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fXwo+Pj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+Pj4gSW50ZWwtZ2Z4QGxpc3Rz
LmZyZWVkZXNrdG9wLm9yZwo+Pj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu
L2xpc3RpbmZvL2ludGVsLWdmeAo+PiAKPgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv
dXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl
ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv
L2ludGVsLWdmeAo=