Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement

[Anthony Liguori <aliguori@us.ibm.com>]

Cornelia Huck <cornelia.huck@de.ibm.com> writes:

> On Tue, 16 Jul 2013 15:10:41 +0800
> Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
>> > Considering what the patch looks like, I don't think it's a huge
>> > problem...  In fact, perhaps x-data-plane could be even added to
>> > DEFINE_VIRTIO_BLK_PROPERTIES.  This would make it clear that support for
>> > non-ioeventfd hosts (including TCG) is one of the things to do to make
>> > data plane the default.
>> 
>> I agree.  Since this patch is so minimal it will not add extra work as
>> we reintegrate dataplane into core QEMU.
>> 
>> Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
>> 
> Thank you.
>
> Any further guidelines on when to ask for acks from you guys?

Three days between a post and pull request is a bit short especially
with no feedback.  That was my primary concern here.

Regards,

Anthony Liguori

> The mode
> I've been operating in is mostly "if virtio-pci provides this feature,
> it shouldn't be half bad and we want it in virtio-ccw as well in order
> to keep things consistent and get more test coverage".
>
> (dataplane has been enabled in our internal testing for some time now,
> I just had asked Dominik to re-do his patch with a proper description
> as we had some code churn in our internal repository.)