All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 6/6] ath10k: cleanup ath10k_pci_stop_intr()
Date: Tue, 30 Apr 2013 10:23:11 +0300	[thread overview]
Message-ID: <87zjwglbxc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1366962748-6660-7-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 26 Apr 2013 09:52:28 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> +	/* There's at least one interrupt irregardless whether its legacy INTR
> +	 * or MSI or MSI-X */
> +	for (i = 0; i < min(1, ar_pci->num_msi_intrs); i++)
> +		free_irq(ar_pci->pdev->irq + i, ar);

I'm not sure about this. If num_msi_intrs is 5 we still free only the
first irq? Did I understood this correctly?

-- 
Kalle Valo

  reply	other threads:[~2013-04-30  7:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26  7:52 [ath9k-devel] [PATCH 0/6] ath10k: coding style cleanup Michal Kazior
2013-04-26  7:52 ` [ath9k-devel] [PATCH 1/6] ath10k: fix code style and add comments to tx code Michal Kazior
2013-04-26  7:52 ` [ath9k-devel] [PATCH 2/6] ath10k: tweak ath10k_pci_diag_read_mem() prototype Michal Kazior
2013-04-26  7:52 ` [ath9k-devel] [PATCH 3/6] ath10k: tweak ath10k_pci_diag_write_mem() prototype Michal Kazior
2013-04-26  7:52 ` [ath9k-devel] [PATCH 4/6] ath10k: drop unnecessary else branch Michal Kazior
2013-04-26  7:52 ` [ath9k-devel] [PATCH 5/6] " Michal Kazior
2013-04-26  7:52 ` [ath9k-devel] [PATCH 6/6] ath10k: cleanup ath10k_pci_stop_intr() Michal Kazior
2013-04-30  7:23   ` Kalle Valo [this message]
2013-04-30  7:51     ` Michal Kazior
2013-04-30 11:13 ` [ath9k-devel] [PATCH v2 0/6] ath10k: coding style cleanup Michal Kazior
2013-04-30 11:13   ` [ath9k-devel] [PATCH v2 1/6] ath10k: fix code style and add comments to tx code Michal Kazior
2013-04-30 11:13   ` [ath9k-devel] [PATCH v2 2/6] ath10k: tweak ath10k_pci_diag_read_mem() prototype Michal Kazior
2013-04-30 11:13   ` [ath9k-devel] [PATCH v2 3/6] ath10k: tweak ath10k_pci_diag_write_mem() prototype Michal Kazior
2013-04-30 11:13   ` [ath9k-devel] [PATCH v2 4/6] ath10k: drop unnecessary else branch Michal Kazior
2013-04-30 11:13   ` [ath9k-devel] [PATCH v2 5/6] " Michal Kazior
2013-04-30 11:13   ` [ath9k-devel] [PATCH v2 6/6] ath10k: cleanup ath10k_pci_stop_intr() Michal Kazior
2013-04-30 11:49   ` [ath9k-devel] [PATCH v2 0/6] ath10k: coding style cleanup Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjwglbxc.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.