From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URkaQ-0008RJ-DC for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:40:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URkaK-0000pA-In for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:40:50 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:46688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URkaJ-0000oj-So for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:40:44 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Apr 2013 00:29:10 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id A45A4357804A for ; Tue, 16 Apr 2013 00:40:37 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3FEdeFB61997168 for ; Tue, 16 Apr 2013 00:39:40 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3FEdjiI019943 for ; Tue, 16 Apr 2013 00:39:45 +1000 From: Anthony Liguori In-Reply-To: <516BFCE0.6020005@redhat.com> References: <1365311880-11800-1-git-send-email-peter.crosthwaite@xilinx.com> <878v4kvt54.fsf@codemonkey.ws> <516BFCE0.6020005@redhat.com> Date: Mon, 15 Apr 2013 09:39:15 -0500 Message-ID: <87zjwzg8oc.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Crosthwaite , qemu-devel@nongnu.org Paolo Bonzini writes: > Il 15/04/2013 15:08, Anthony Liguori ha scritto: >>> > Signed-off-by: Peter Crosthwaite >> I'm going through patches for 1.5 candidates. >> >> I believe the paste performance issue has been resolved now and this >> patch is no longer needed. I can't find a definitive statement on the >> list for that though. >> >> Peter, can you confirm? > > Kind of. > > There is one remaining patch, Yeah, I'm testing this right now. > http://article.gmane.org/gmane.comp.emulators.qemu/205376. Amit says he > sees a problem with it, but I cannot reproduce. But the patch is > obvious and the problem must be latent, so I would apply it anyway. So far, I haven't encountered a problem with it and that includes doing virtio-serial testing. If I don't see a problem, I'll push it as I agree the patch looks obviously correct to me. > There is another issue pointed out by Michael Hines with "-serial pty". > I couldn't reproduce it, but I haven't tried very hard. There's also a qtest problem that Andreas reported that I can reproduce that I have already begun looking into. Regards, Anthony Liguori > > Paolo