From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 8/9] ARM: omap3: cpuidle: enable time keeping Date: Wed, 03 Apr 2013 10:47:23 -0700 Message-ID: <87zjxfzetw.fsf@linaro.org> References: <1364991322-20585-1-git-send-email-daniel.lezcano@linaro.org> <1364991322-20585-8-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:36754 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759474Ab3DCRr2 (ORCPT ); Wed, 3 Apr 2013 13:47:28 -0400 Received: by mail-pa0-f41.google.com with SMTP id kx1so1035526pab.14 for ; Wed, 03 Apr 2013 10:47:27 -0700 (PDT) In-Reply-To: <1364991322-20585-8-git-send-email-daniel.lezcano@linaro.org> (Daniel Lezcano's message of "Wed, 3 Apr 2013 14:15:21 +0200") Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Daniel Lezcano Cc: rjw@sisk.pl, linux-pm@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, rnayak@ti.com, swarren@wwwdotorg.org, linux-tegra@vger.kernel.org, horms+renesas@verge.net.au, santosh.shilimkar@ti.com, arnd@arndb.de, lenb@kernel.org, nsekhar@ti.com, josephl@nvidia.com, deepthi@linux.vnet.ibm.com Daniel Lezcano writes: > The TIME_VALID flag is specified for the different states but > the time residency computation is not done, no tk flag, no time > computation in the idle function. > > Set the en_core_tk_irqen flag to activate it. > > Signed-off-by: Daniel Lezcano > Acked-by: Santosh Shilimkar Acked-by: Kevin Hilman Also, is this a regression fix that also needs to hit v3.9? Kevin > --- > arch/arm/mach-omap2/cpuidle34xx.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c > index 80392fc..4f67a5b 100644 > --- a/arch/arm/mach-omap2/cpuidle34xx.c > +++ b/arch/arm/mach-omap2/cpuidle34xx.c > @@ -274,8 +274,9 @@ static int omap3_enter_idle_bm(struct cpuidle_device *dev, > static DEFINE_PER_CPU(struct cpuidle_device, omap3_idle_dev); > > static struct cpuidle_driver omap3_idle_driver = { > - .name = "omap3_idle", > - .owner = THIS_MODULE, > + .name = "omap3_idle", > + .owner = THIS_MODULE, > + .en_core_tk_irqen = 1, > .states = { > { > .enter = omap3_enter_idle_bm, From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@linaro.org (Kevin Hilman) Date: Wed, 03 Apr 2013 10:47:23 -0700 Subject: [PATCH 8/9] ARM: omap3: cpuidle: enable time keeping In-Reply-To: <1364991322-20585-8-git-send-email-daniel.lezcano@linaro.org> (Daniel Lezcano's message of "Wed, 3 Apr 2013 14:15:21 +0200") References: <1364991322-20585-1-git-send-email-daniel.lezcano@linaro.org> <1364991322-20585-8-git-send-email-daniel.lezcano@linaro.org> Message-ID: <87zjxfzetw.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Daniel Lezcano writes: > The TIME_VALID flag is specified for the different states but > the time residency computation is not done, no tk flag, no time > computation in the idle function. > > Set the en_core_tk_irqen flag to activate it. > > Signed-off-by: Daniel Lezcano > Acked-by: Santosh Shilimkar Acked-by: Kevin Hilman Also, is this a regression fix that also needs to hit v3.9? Kevin > --- > arch/arm/mach-omap2/cpuidle34xx.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c > index 80392fc..4f67a5b 100644 > --- a/arch/arm/mach-omap2/cpuidle34xx.c > +++ b/arch/arm/mach-omap2/cpuidle34xx.c > @@ -274,8 +274,9 @@ static int omap3_enter_idle_bm(struct cpuidle_device *dev, > static DEFINE_PER_CPU(struct cpuidle_device, omap3_idle_dev); > > static struct cpuidle_driver omap3_idle_driver = { > - .name = "omap3_idle", > - .owner = THIS_MODULE, > + .name = "omap3_idle", > + .owner = THIS_MODULE, > + .en_core_tk_irqen = 1, > .states = { > { > .enter = omap3_enter_idle_bm,