From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40794)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TazJg-0001UT-Jv
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 20:41:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TazJf-0000PV-No
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 20:41:28 -0500
Received: from mail-ob0-f173.google.com ([209.85.214.173]:64427)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TazJf-0000In-J4
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 20:41:27 -0500
Received: by mail-ob0-f173.google.com with SMTP id x4so6170949obh.4
	for <qemu-devel@nongnu.org>; Tue, 20 Nov 2012 17:41:27 -0800 (PST)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <4174418d72ef8966c94434a814c2a67d5d33f646.1353421334.git.amit.shah@redhat.com>
References: <cover.1353421334.git.amit.shah@redhat.com>
	<4174418d72ef8966c94434a814c2a67d5d33f646.1353421334.git.amit.shah@redhat.com>
Date: Tue, 20 Nov 2012 19:41:22 -0600
Message-ID: <87zk2bka0t.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device
	removal
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu list <qemu-devel@nongnu.org>

Amit Shah <amit.shah@redhat.com> writes:

> Disable the rate-limit timer on device remove (e.g. hot-unplug).
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>

Nice catch.

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>  hw/virtio-rng.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
> index cf5a8ff..c8a6da7 100644
> --- a/hw/virtio-rng.c
> +++ b/hw/virtio-rng.c
> @@ -194,6 +194,8 @@ void virtio_rng_exit(VirtIODevice *vdev)
>  {
>      VirtIORNG *vrng = DO_UPCAST(VirtIORNG, vdev, vdev);
>  
> +    qemu_del_timer(vrng->rate_limit_timer);
> +    qemu_free_timer(vrng->rate_limit_timer);
>      unregister_savevm(vrng->qdev, "virtio-rng", vrng);
>      virtio_cleanup(vdev);
>  }
> -- 
> 1.8.0