From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [RFCv2 1/2] virtio_console: Add support for DMA memory allocation
Date: Mon, 10 Sep 2012 17:23:52 +0930
Message-ID: <87zk4ye2jz.fsf@rustcorp.com.au>
References: <1347001066-13521-1-git-send-email-sjur.brandeland@stericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <virtualization-bounces@lists.linux-foundation.org>
In-Reply-To: <1347001066-13521-1-git-send-email-sjur.brandeland@stericsson.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
To: "Michael S . Tsirkin" <mst@redhat.com>
Cc: Sjur =?utf-8?Q?Br=C3=A6ndeland?= <sjurbren@gmail.com>, Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Amit Shah <amit.shah@redhat.com>, Sjur =?utf-8?Q?Br=C3=A6ndeland?= <sjur.brandeland@stericsson.com>
List-Id: virtualization@lists.linuxfoundation.org

c2p1ci5icmFuZGVsYW5kQHN0ZXJpY3Nzb24uY29tIHdyaXRlczoKCj4gRnJvbTogU2p1ciBCcsOm
bmRlbGFuZCA8c2p1ci5icmFuZGVsYW5kQHN0ZXJpY3Nzb24uY29tPgo+Cj4gQWRkIGZlYXR1cmUg
VklSVElPX0NPTlNPTEVfRl9ETUFfTUVNLiBJZiB0aGUgYXJjaGl0ZWN0dXJlIGhhcwo+IERNQSBz
dXBwb3J0IGFuZCB0aGlzIGZlYXR1cmUgYml0IGlzIHNldCwgdGhlIHZpcnRpbyBkYXRhIGJ1ZmZl
cnMKPiB3aWxsIGJlIGFsbG9jYXRlZCBmcm9tIERNQSBtZW1vcnkuIElmIHRoZSBkZXZpY2UgcmVx
dWVzdHMKPiB0aGUgZmVhdHVyZSBWSVJUSU9fQ09OU09MRV9GX0RNQV9NRU0sIGJ1dCB0aGUgYXJj
aGl0ZWN0dXJlCj4gZG9uJ3Qgc3VwcG9ydCBETUEgdGhlIGRyaXZlcidzIHByb2JlIGZ1bmN0aW9u
IHdpbGwgZmFpbC4KPgo+IFRoaXMgaXMgbmVlZGVkIGZvciB1c2luZyB2aXJ0aW9fY29uc29sZSBm
cm9tIHRoZSByZW1vdGVwcm9jCj4gZnJhbWV3b3JrLgoKU29ycnkgZm9yIHRoZSBiYWNrIGFuZCBm
b3J0aCwgSSd2ZSBiZWVuIHBvbmRlcmluZyBNU1QncyBwb2ludHMuCgpJZiB3ZSBtYWtlIGEgbmV3
IGRtYS1tdWx0aXBvcnQgZGV2aWNlIChlZy4gSUQgMTEpLCBob3cgdWdseSBpcyB0aGUgY29kZT8K
Ckl0IHdvdWxkIGJlIGEgdmlydGlvIGNvbnNvbGUgd2l0aCBETUEgYnVmZmVycyBhbmQgbm8gY29u
c29sZSwganVzdCB0aGUKbXVsdGlwb3J0IHN0dWZmLiAgVGhpcyB3b3VsZCBoYXZlIG5vIGltcGFj
dCBvbiB0aGUgY3VycmVudCBzcGVjIGZvcgp2aXJ0aW8gY29uc29sZS4KClRoYW5rcywKUnVzdHku
Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxp
emF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9u
Lm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92
aXJ0dWFsaXphdGlvbg==

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755457Ab2IJIEh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 10 Sep 2012 04:04:37 -0400
Received: from ozlabs.org ([203.10.76.45]:42013 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753385Ab2IJIEN convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 10 Sep 2012 04:04:13 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
To: sjur.brandeland@stericsson.com, "Michael S . Tsirkin" <mst@redhat.com>
Cc: Sjur =?utf-8?Q?Br=C3=A6ndeland?= <sjurbren@gmail.com>,
        Sjur =?utf-8?Q?Br=C3=A6ndeland?= <sjur.brandeland@stericsson.com>,
        Amit Shah <amit.shah@redhat.com>, Ohad Ben-Cohen <ohad@wizery.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFCv2 1/2] virtio_console: Add support for DMA memory allocation
In-Reply-To: <1347001066-13521-1-git-send-email-sjur.brandeland@stericsson.com>
References: <1347001066-13521-1-git-send-email-sjur.brandeland@stericsson.com>
User-Agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu)
Date: Mon, 10 Sep 2012 17:23:52 +0930
Message-ID: <87zk4ye2jz.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

sjur.brandeland@stericsson.com writes:

> From: Sjur Brændeland <sjur.brandeland@stericsson.com>
>
> Add feature VIRTIO_CONSOLE_F_DMA_MEM. If the architecture has
> DMA support and this feature bit is set, the virtio data buffers
> will be allocated from DMA memory. If the device requests
> the feature VIRTIO_CONSOLE_F_DMA_MEM, but the architecture
> don't support DMA the driver's probe function will fail.
>
> This is needed for using virtio_console from the remoteproc
> framework.

Sorry for the back and forth, I've been pondering MST's points.

If we make a new dma-multiport device (eg. ID 11), how ugly is the code?

It would be a virtio console with DMA buffers and no console, just the
multiport stuff.  This would have no impact on the current spec for
virtio console.

Thanks,
Rusty.