From: Kevin Hilman <khilman@ti.com>
To: "Raja, Govindraj" <govindraj.raja@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>, Joe Woodward <jw@terrafix.co.uk>,
linux-omap@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
neilb@suse.de
Subject: Re: Suspend broken on 3.3?
Date: Mon, 09 Apr 2012 07:27:22 -0700 [thread overview]
Message-ID: <87zkalc75h.fsf@ti.com> (raw)
In-Reply-To: <CAMrsUdLMYVwd3rupHtrNKC0rMvx1-3B=4usOh8cwTUy8DX_hVg@mail.gmail.com> (Govindraj Raja's message of "Mon, 9 Apr 2012 16:57:23 +0530")
"Raja, Govindraj" <govindraj.raja@ti.com> writes:
[...]
> So incase of uart wakeups are disabled and uart tx/rx is requested
> can we prevent MPU from low power state.
I think that would be a mistake.
The main point of disabling UART wakeups is to save power by preventing
unwanted wakups on UARTs that don't need/want them. If we then leave
MPU enabled because UART wakeups are disabled, that would defeat the
power-saving goals of disabling wakeups in the first place.
Presumably, if a user disables UART wakeups, it means either 1) that
UART is not used or 2) performance is not critical.
IMO, we simply need to ensure that the defaults are correct. When UARTs
are initialized/enabled wakeups should be enabled by default. The user
can then override this if desired, and will obviously see a performance
impact. But that's what happens with wakeups disabled.
Kevin
next prev parent reply other threads:[~2012-04-09 14:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 11:09 Suspend broken on 3.3? Joe Woodward
2012-03-22 17:33 ` Kevin Hilman
2012-03-26 13:41 ` Joe Woodward
2012-03-27 0:34 ` Kevin Hilman
2012-03-27 13:53 ` Raja, Govindraj
2012-03-27 21:37 ` Kevin Hilman
2012-03-28 10:59 ` Raja, Govindraj
2012-03-28 15:38 ` Joe Woodward
2012-03-28 17:46 ` Kevin Hilman
2012-03-29 8:35 ` Joe Woodward
2012-03-29 9:14 ` Shubhrajyoti Datta
2012-03-29 9:46 ` Joe Woodward
2012-03-29 10:26 ` Paul Walmsley
2012-03-29 11:27 ` Joe Woodward
2012-03-29 11:40 ` Joe Woodward
2012-03-29 14:29 ` Raja, Govindraj
2012-03-30 7:53 ` Joe Woodward
2012-03-30 8:46 ` Raja, Govindraj
2012-03-30 9:26 ` Joe Woodward
2012-03-30 10:15 ` Raja, Govindraj
2012-03-30 11:04 ` Joe Woodward
2012-03-30 12:24 ` Raja, Govindraj
2012-04-02 10:43 ` Raja, Govindraj
2012-04-02 12:37 ` Joe Woodward
2012-04-03 6:56 ` Govindraj
2012-04-04 14:56 ` Paul Walmsley
2012-04-04 16:13 ` Raja, Govindraj
2012-04-06 0:29 ` Paul Walmsley
2012-04-06 14:21 ` Kevin Hilman
2012-04-09 11:27 ` Raja, Govindraj
2012-04-09 14:27 ` Kevin Hilman [this message]
2012-04-09 16:01 ` Paul Walmsley
2012-04-09 17:10 ` Kevin Hilman
2012-04-10 9:26 ` Raja, Govindraj
2012-04-10 18:03 ` Kevin Hilman
2012-04-11 13:13 ` Raja, Govindraj
2012-04-11 19:34 ` Paul Walmsley
2012-04-12 11:51 ` Raja, Govindraj
2012-03-27 14:39 ` Joe Woodward
2012-03-27 21:28 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkalc75h.fsf@ti.com \
--to=khilman@ti.com \
--cc=balbi@ti.com \
--cc=govindraj.raja@ti.com \
--cc=jw@terrafix.co.uk \
--cc=linux-omap@vger.kernel.org \
--cc=neilb@suse.de \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.