From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arm/mach-pxa: add pulse width modulator controller
Date: Fri, 27 Jan 2012 17:07:04 +0100 [thread overview]
Message-ID: <87zkd9gmdz.fsf@free.fr> (raw)
In-Reply-To: <20120127114210.GC5446@pengutronix.de> (Sascha Hauer's message of "Fri, 27 Jan 2012 12:42:10 +0100")
Sascha Hauer <s.hauer@pengutronix.de> writes:
> On Thu, Jan 26, 2012 at 08:55:28PM +0100, Robert Jarzmik wrote:
>> Add PXA embedded pulse width modulator support. The PWM can
>> generate signals from 49.6kHz to 1.625MHz.
>>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> ---
>
> [...]
>
>> +
>> + /* NOTE: the clock to PWM has to be enabled first
>> + * before writing to the registers
>> + */
>
> Does this mean that pwm_enable() has to be called prior to pxm_config()?
Yes.
> I think we should rather have a real pwm API.
So do I.
> The following Kernel patch could be easily adopted and the overhead is
> acceptable I think.
Would you adapt it or do you want me to do it ?
> The problem is that once we let PXA implement pwm functions we cannot support
> other pwms in the same binary. On i.MX for example we have dedicated PWM
> controllers which most people use, but some others use a pwm internal to the
> framebuffer controller.
True. That's a good reason to have your framework implemented. I don't think the
rework of my patch on top of the framework will take me a lot of time.
Cheers.
--
Robert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-01-27 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 19:55 [PATCH] drivers/mtd: fix mtdraw write support Robert Jarzmik
2012-01-26 19:55 ` [PATCH] drivers/mtd: fix docg3 " Robert Jarzmik
2012-01-26 19:55 ` [PATCH] arm/mach-pxa: add standard LCD panel GPIO settings Robert Jarzmik
2012-01-26 19:55 ` [PATCH] arm/mach-pxa: add CCCR bits definitions Robert Jarzmik
2012-01-26 19:55 ` [PATCH] arm/mach-pxa: add pulse width modulator controller Robert Jarzmik
2012-01-27 11:42 ` Sascha Hauer
2012-01-27 16:07 ` Robert Jarzmik [this message]
2012-01-31 9:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkd9gmdz.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.