From: Rusty Russell <rusty@rustcorp.com.au>
To: Jiri Kosina <jkosina@suse.cz>, Andrew Morton <akpm00@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kmod: prevent kmod_loop_msg overflow in __request_module()
Date: Tue, 04 Oct 2011 10:47:28 +1030 [thread overview]
Message-ID: <87zkhhhap3.fsf@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LNX.2.00.1109292337030.24692@pobox.suse.cz>
On Fri, 30 Sep 2011 00:18:17 +0200 (CEST), Jiri Kosina <jkosina@suse.cz> wrote:
> On Thu, 29 Sep 2011, Andrew Morton wrote:
> > Well, it will take two billion passes through here to cause the
> > overflow. I really hope you found this problem by inspection!
>
> Unfortunately not, it was more painful experience than code reading :)
Cool!
Changing it to unsigned would have helped too. But I've applied
this....
Thanks,
Rusty.
next prev parent reply other threads:[~2011-10-04 1:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 15:50 [PATCH] kmod: prevent kmod_loop_msg overflow in __request_module() Jiri Kosina
2011-09-29 21:31 ` Andrew Morton
2011-09-29 22:18 ` Jiri Kosina
2011-10-04 0:17 ` Rusty Russell [this message]
2011-10-04 9:37 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkhhhap3.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm00@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.