From: Kevin Hilman <khilman@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org,
Vishwanath Sripathy <vishwanath.bs@ti.com>
Subject: Re: [RFC 1/2] OMAP3+: voltage / oscillator parameter segregation
Date: Fri, 26 Aug 2011 16:24:44 -0700 [thread overview]
Message-ID: <87zkivwybn.fsf@ti.com> (raw)
In-Reply-To: <CAOMWX4cTsoK_ejOq861wNMiUDJYjcvPtc+jLo3z398D-Y2e39w@mail.gmail.com> (Nishanth Menon's message of "Sun, 7 Aug 2011 11:30:21 -0500")
Hi Nishanth,
"Menon, Nishanth" <nm@ti.com> writes:
> here is my quick feedback:
>
>
> On Wed, Aug 3, 2011 at 10:29, Tero Kristo <t-kristo@ti.com> wrote:
>>
>> This patch separates board specific voltage and oscillator ramp / setup
>> times from the core code. Things changed:
>>
>> - on/sleep/ret/off voltage setup moved from common twl code to
>> VC / VP data (oppxxxx_data.c files)
>> - added board support for vdd ramp up / down times
>> - added board support for oscillator setup time declaration
>>
>> Todo: split patch into more easily manageable parts.
>>
>> Applies on top of pm/wip/voltdm branch, based on work done by Vishwanath
>> Sripathy.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> Cc: Vishwanath Sripathy <vishwanath.bs@ti.com>
[...]
>> diff --git a/arch/arm/mach-omap2/opp3xxx_data.c b/arch/arm/mach-omap2/opp3xxx_data.c
>> index d95f3f9..b5d8294 100644
>> --- a/arch/arm/mach-omap2/opp3xxx_data.c
>> +++ b/arch/arm/mach-omap2/opp3xxx_data.c
>> @@ -26,6 +26,16 @@
>> #include "pm.h"
>>
>> /* 34xx */
>> +/* OMAP VP parameter values */
>> +#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14
>> +#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42
>> +#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18
>> +#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c
> NAK -> we should be using voltages here -> depending on the PMIC used,
> the rounding factor may not map to TWL4030.
Agreed.
> I had posted patch for this earlier I believe in series
> http://marc.info/?l=linux-omap&m=130741297821372&w=2
I know you're a bit distracted currently ;) but is there any chance you
can refresh at least this patch:
OMAP3+: PM: VP: use uV for max and min voltage limits
from your series on top of my current pm-wip/voltdm branch?
If not, maybe point us to an archived version and Tero can pick it up
and add it to this series. After a quick search, I couldn't find it in
the marc.info archives.
Thanks,
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-26 23:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 15:29 [RFC 0/2] voltage / oscillator parameter segregation Tero Kristo
2011-08-03 15:29 ` [RFC 1/2] OMAP3+: " Tero Kristo
2011-08-04 13:57 ` Vishwanath Sripathy
2011-08-05 7:28 ` Tero Kristo
2011-08-07 16:30 ` Menon, Nishanth
2011-08-26 23:24 ` Kevin Hilman [this message]
2011-08-27 9:29 ` Vishwanath Sripathy
2011-08-29 16:07 ` Kevin Hilman
2011-08-03 15:29 ` [RFC 2/2] TEMP: OMAP3: beagle: added dummy vdd ramp up and clock setup times Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkivwybn.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.