All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] libxt_TCPMSS.c: unbreak build without ipv6 after ea2a02f7
Date: Fri, 22 Jul 2011 12:49:35 +0200	[thread overview]
Message-ID: <87zkk6y4hs.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <alpine.LNX.2.01.1107221227180.4330@frira.zrqbmnf.qr> (Jan Engelhardt's message of "Fri, 22 Jul 2011 12:31:04 +0200 (CEST)")

>>>>> "Jan" == Jan Engelhardt <jengelh@medozas.de> writes:

Hi,

 >> But those structs define the network format of ipv4 and ipv6 headers, so
 >> they are not likely to change.

 Jan> I was pondering on a hypothetical implementation with CHAR_BIT=16.

Using iptables? Even so, the ipv6 header would need to be the same to be
able to communicate with other ipv6 hosts.

 Jan> How about 
 Jan> http://dev.medozas.de/gitweb.cgi?p=iptables;a=commitdiff;h=4d8656ad9d0afd04820f125a85a7b673c7e74fe6

That works as well (if we assume that all systems have netinet/ip.h even
when built with --disable-ipv4):

checking size of struct ip6_hdr... 0

So you end up with a wrong TCPMSS6_opts.max value (UINT16_MAX), but that
presumably doesn't matter if you don't use ipv6.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2011-07-22 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22  5:24 [PATCH] libxt_TCPMSS.c: unbreak build without ipv6 after ea2a02f7 Peter Korsgaard
2011-07-22  9:59 ` Jan Engelhardt
2011-07-22 10:25   ` Peter Korsgaard
2011-07-22 10:31     ` Jan Engelhardt
2011-07-22 10:49       ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zkk6y4hs.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.