From: Kevin Hilman <khilman@ti.com>
To: Shubhrajyoti D <shubhrajyoti@ti.com>
Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] OMAP4: I2C : I2C context save
Date: Thu, 14 Jul 2011 08:52:46 -0700 [thread overview]
Message-ID: <87zkkgoo4x.fsf@ti.com> (raw)
In-Reply-To: 1309933145-8825-1-git-send-email-shubhrajyoti@ti.com (Shubhrajyoti D.'s message of "2011-07-06 6:31:05")
Shubhrajyoti D <shubhrajyoti@ti.com> writes:
> Restore of context is not done for OMAP4. This patch
Subject says context *save*, here says context *restore.*
> adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
> hwmod which activates the restore for OMAP4.
s/hwmod/hwmod data/
> Currently the OMAP4 doesnot hit device off still the
s/doesnot/does not/
> driver may have support for it.
Also, since this is a patch to the hwmod data, the subject
prefix should be something like:
OMAP4: hwmod_data: I2C: set flag to restore context
or something similar.
Also, this is the 2nd (or maybe 3rd) version of this patch posted.
Please version the patch using [PATCH vN].
Kevin
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> Applies on top of patches from Andy Green
> http://www.spinics.net/lists/linux-i2c/msg05632.html
> Tested on OMAP4430
>
> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 0fe9556..5e2c748 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
> };
>
> static struct omap_i2c_dev_attr i2c_dev_attr = {
> - .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
> + .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
> + OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
> };
>
> /* i2c1 */
next reply other threads:[~2011-07-14 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 15:52 Kevin Hilman [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-06 6:19 [PATCH] OMAP4: I2C : I2C context save Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkkgoo4x.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.