Re: [PATCH] logging branch deletion to help recovering from mistakes

["Štěpán Němec" <stepnem@gmail.com>]

Junio C Hamano <gitster@pobox.com> writes:

[...]

Just two cosmetic nits I noticed:

> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index d82c0da..bdf90eb 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -351,6 +351,12 @@ This value is true by default in a repository that has
>  a working directory associated with it, and false by
>  default in a bare repository.
>  
> +core.logRefDeletion::
> +	Enable logging of eletion of refs (e.g. branches), allowing `git
                          ^^^^^^^

[...]

> diff --git a/refs.c b/refs.c
> index e3c0511..afdd634 100644
> --- a/refs.c
> +++ b/refs.c

[...]

> -	/* removing the loose one could have resurrected an earlier
> -	 * packed one.  Also, if it was not loose we need to repack
> -	 * without it.
> -	 */

Could also the first sentence start with a capital letter?

[...]

> +		if (!(delopt & REF_NODEREF))
> +			lock->lk->filename[i] = '.';
> +	}
> +	/*
> +	 * removing the loose one could have resurrected an earlier
> +	 * packed one.  Also, if it was not loose we need to repack
> +	 * without it.
> +	 */

Same here.

Thank you,

  Štěpán