From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset Date: Tue, 09 Nov 2010 09:31:41 -0800 Message-ID: <87zktiqu82.fsf@deeprootsystems.com> References: <1289226250-11366-1-git-send-email-manjugk@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pv0-f174.google.com ([74.125.83.174]:53438 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752278Ab0KIRbs (ORCPT ); Tue, 9 Nov 2010 12:31:48 -0500 Received: by pva4 with SMTP id 4so280904pva.19 for ; Tue, 09 Nov 2010 09:31:48 -0800 (PST) In-Reply-To: <1289226250-11366-1-git-send-email-manjugk@ti.com> (Manjunath Kondaiah G.'s message of "Mon, 8 Nov 2010 19:54:10 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "G, Manjunath Kondaiah" Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Charulatha V , Paul Walmsley , Rajendra Nayak , Benoit Cousson "G, Manjunath Kondaiah" writes: > The commit '311225e6' is missing '.module_offs' in prcm > structure in omap3 hwmod data base which results in accessing > wrong register for I2Cx IDLEST bit monitoring. > > Added module offsets for accessing register CM_IDLEST1_CORE. > > Patch tested on Zoom3 using omap2plus_defconfig Thanks, will fold this into original series. Kevin > Signed-off-by: G, Manjunath Kondaiah > Signed-off-by: Charulatha V > Cc: Kevin Hilman > Cc: Paul Walmsley > Cc: Rajendra Nayak > Cc: Benoit Cousson > --- > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > index d0d8030..22831e9 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > @@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = { > .main_clk = "i2c1_fck", > .prcm = { > .omap2 = { > + .module_offs = CORE_MOD, > .prcm_reg_id = 1, > .module_bit = OMAP3430_EN_I2C1_SHIFT, > .idlest_reg_id = 1, > @@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = { > .main_clk = "i2c2_fck", > .prcm = { > .omap2 = { > + .module_offs = CORE_MOD, > .prcm_reg_id = 1, > .module_bit = OMAP3430_EN_I2C2_SHIFT, > .idlest_reg_id = 1, > @@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = { > .main_clk = "i2c3_fck", > .prcm = { > .omap2 = { > + .module_offs = CORE_MOD, > .prcm_reg_id = 1, > .module_bit = OMAP3430_EN_I2C3_SHIFT, > .idlest_reg_id = 1, From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@deeprootsystems.com (Kevin Hilman) Date: Tue, 09 Nov 2010 09:31:41 -0800 Subject: [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset In-Reply-To: <1289226250-11366-1-git-send-email-manjugk@ti.com> (Manjunath Kondaiah G.'s message of "Mon, 8 Nov 2010 19:54:10 +0530") References: <1289226250-11366-1-git-send-email-manjugk@ti.com> Message-ID: <87zktiqu82.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org "G, Manjunath Kondaiah" writes: > The commit '311225e6' is missing '.module_offs' in prcm > structure in omap3 hwmod data base which results in accessing > wrong register for I2Cx IDLEST bit monitoring. > > Added module offsets for accessing register CM_IDLEST1_CORE. > > Patch tested on Zoom3 using omap2plus_defconfig Thanks, will fold this into original series. Kevin > Signed-off-by: G, Manjunath Kondaiah > Signed-off-by: Charulatha V > Cc: Kevin Hilman > Cc: Paul Walmsley > Cc: Rajendra Nayak > Cc: Benoit Cousson > --- > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > index d0d8030..22831e9 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > @@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = { > .main_clk = "i2c1_fck", > .prcm = { > .omap2 = { > + .module_offs = CORE_MOD, > .prcm_reg_id = 1, > .module_bit = OMAP3430_EN_I2C1_SHIFT, > .idlest_reg_id = 1, > @@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = { > .main_clk = "i2c2_fck", > .prcm = { > .omap2 = { > + .module_offs = CORE_MOD, > .prcm_reg_id = 1, > .module_bit = OMAP3430_EN_I2C2_SHIFT, > .idlest_reg_id = 1, > @@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = { > .main_clk = "i2c3_fck", > .prcm = { > .omap2 = { > + .module_offs = CORE_MOD, > .prcm_reg_id = 1, > .module_bit = OMAP3430_EN_I2C3_SHIFT, > .idlest_reg_id = 1,