All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Reddy, Teerth" <teerth@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
Date: Thu, 27 Aug 2009 11:25:24 +0300	[thread overview]
Message-ID: <87zl9lfytn.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB0309E9CD4D@dbde02.ent.ti.com> (Teerth Reddy's message of "Mon\, 24 Aug 2009 11\:58\:59 +0530")

Hi Teerth,

"Reddy, Teerth" <teerth@ti.com> writes:

> From : Teerth Reddy <teerth@ti.com>
>
> This patch changes for setting the padconf value for sys_nirq line
> which is connected to T2 INTR1.  This will fix the T2 keypad wakeup
> issue on OMAP3 SDP.
>
> Signed-off-by: Teerth Reddy < teerth@ti.com >

Patch looks good, thanks.  I'll pull this into PM branch and queue
in my PM fixes queue for next merge window.

I did a minor update by adding a comment in the
enable_board_wakeup_source function stating that this is the
interrupt pin used for T2.

Kevin

> ---
>  arch/arm/mach-omap2/board-3430sdp.c   |    6 ++++++
>  arch/arm/mach-omap2/mux.c             |    5 +++++
>  arch/arm/plat-omap/include/mach/mux.h |    3 +++
>  3 files changed, 14 insertions(+)
>
> Index: linux-omap-pm/arch/arm/mach-omap2/board-3430sdp.c
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/mach-omap2/board-3430sdp.c
> +++ linux-omap-pm/arch/arm/mach-omap2/board-3430sdp.c
> @@ -574,6 +574,11 @@ static inline void board_smc91x_init(voi
>  
>  #endif
>  
> +static void enable_board_wakeup_source(void)
> +{
> +	omap_cfg_reg(AF26_34XX_SYS_NIRQ);
> +}
> +
>  static void __init omap_3430sdp_init(void)
>  {
>  	omap3430_i2c_init();
> @@ -590,6 +595,7 @@ static void __init omap_3430sdp_init(voi
>  	usb_musb_init();
>  	board_smc91x_init();
>  	usb_ehci_init(EHCI_HCD_OMAP_MODE_PHY, true, true, 57, 61);
> +	enable_board_wakeup_source();
>  }
>  
>  static void __init omap_3430sdp_map_io(void)
> Index: linux-omap-pm/arch/arm/mach-omap2/mux.c
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/mach-omap2/mux.c
> +++ linux-omap-pm/arch/arm/mach-omap2/mux.c
> @@ -492,6 +492,11 @@ MUX_CFG_34XX("H16_34XX_SDRC_CKE0", 0x262
>  		OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_OUTPUT)
>  MUX_CFG_34XX("H17_34XX_SDRC_CKE1", 0x264,
>  		OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_OUTPUT)
> +
> +/* SYS_NIRQ T2 INT1 */
> +MUX_CFG_34XX("AF26_34XX_SYS_NIRQ", 0x1E0,
> +		OMAP3_WAKEUP_EN | OMAP34XX_PIN_INPUT_PULLUP |
> +		OMAP34XX_MUX_MODE0)
>  };
>  
>  #define OMAP34XX_PINS_SZ	ARRAY_SIZE(omap34xx_pins)
> Index: linux-omap-pm/arch/arm/plat-omap/include/mach/mux.h
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/plat-omap/include/mach/mux.h
> +++ linux-omap-pm/arch/arm/plat-omap/include/mach/mux.h
> @@ -857,6 +857,9 @@ enum omap34xx_index {
>  	/* OMAP3 SDRC CKE signals to SDR/DDR ram chips */
>  	H16_34XX_SDRC_CKE0,
>  	H17_34XX_SDRC_CKE1,
> +
> +	/* SYS_NIRQ T2 INT1 */
> +	AF26_34XX_SYS_NIRQ,
>  };
>  
>  struct omap_mux_cfg {

  reply	other threads:[~2009-08-27  8:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-24  6:28 [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3 Reddy, Teerth
2009-08-27  8:25 ` Kevin Hilman [this message]
2009-11-03 16:32   ` Premi, Sanjeev
2009-11-03 22:04     ` Kevin Hilman
2009-11-04 14:01       ` Premi, Sanjeev
2009-11-06 14:12         ` Premi, Sanjeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zl9lfytn.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=teerth@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.