From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MCYVK-00040a-Qy for mharc-grub-devel@gnu.org; Fri, 05 Jun 2009 08:26:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCYVH-0003zx-3J for grub-devel@gnu.org; Fri, 05 Jun 2009 08:26:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCYVB-0003yE-Vk for grub-devel@gnu.org; Fri, 05 Jun 2009 08:26:34 -0400 Received: from [199.232.76.173] (port=38593 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCYVB-0003y8-KO for grub-devel@gnu.org; Fri, 05 Jun 2009 08:26:29 -0400 Received: from smtp-vbr1.xs4all.nl ([194.109.24.21]:4399) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MCYVA-0007CS-VT for grub-devel@gnu.org; Fri, 05 Jun 2009 08:26:29 -0400 Received: from marco (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr1.xs4all.nl (8.13.8/8.13.8) with ESMTP id n55CQRD3039881 for ; Fri, 5 Jun 2009 14:26:28 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1243426603.3425.2.camel@fz.local> <1243865933.3417.2.camel@fz.local> <1244043954.3407.4.camel@fz.local> <874ouwcst9.fsf@xs4all.nl> <1244191623.3416.1.camel@fz.local> <874ouvxao0.fsf@xs4all.nl> <1244197962.3416.13.camel@fz.local> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 05 Jun 2009 14:26:27 +0200 In-Reply-To: <1244197962.3416.13.camel@fz.local> (Felix Zielcke's message of "Fri, 05 Jun 2009 12:32:42 +0200") Message-ID: <87zlcmx3ws.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] add true and false commands X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 12:26:35 -0000 Felix Zielcke writes: > Am Freitag, den 05.06.2009, 12:00 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: >> >> > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: >> >> Felix Zielcke writes: >> >> >> >> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' >> >> > Serbinenko: >> >> >> However convention for >> >> >> creating false is: >> >> >> return grub_error (GRUB_ERR_TEST_FAILURE, "false"); >> >> >> and not >> >> >> return 1; >> >> > >> >> > Ok changed it. If everyone is fine with placing this in normal/main.c, I >> >> > commit it. >> >> >> >> Unless it is essential to do so, please do not place it in >> >> normal/main.c. >> > >> > would normal/misc.c be okay or maybe a new file normal/true.c? >> > I just don't think it's worth to create a new module for these 2 very >> > little commands. >> >> The problem is with too many little commands, the size of normal.mod >> grows. Although the commands are *very* small and I do not strongly >> object to inclusion in normal.mod, if noone else has any objection. > > The binary size of normal.mod would grow about 264 bytes whereas in > minicmd.mod it would be just 260 bytes. > But I already forgot that Bean wants to get rid of normal.mod. > > So what should I do now? > Placing it in normal.mod or minicmd.mod where it's included in rescue > mode or placing it into a true.mod where the size increase would be > bigger? minicmd.mod is not a very descriptive name. Better call is truefalse.mod or something like that. -- Marco