From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LPCRi-0007L7-1p for mharc-grub-devel@gnu.org; Tue, 20 Jan 2009 03:58:54 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPCRg-0007Km-8e for grub-devel@gnu.org; Tue, 20 Jan 2009 03:58:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPCRd-0007KO-JZ for grub-devel@gnu.org; Tue, 20 Jan 2009 03:58:50 -0500 Received: from [199.232.76.173] (port=50529 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPCRd-0007KL-CO for grub-devel@gnu.org; Tue, 20 Jan 2009 03:58:49 -0500 Received: from smtp-vbr5.xs4all.nl ([194.109.24.25]:4065) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LPCRc-0000xD-Sq for grub-devel@gnu.org; Tue, 20 Jan 2009 03:58:49 -0500 Received: from marco (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr5.xs4all.nl (8.13.8/8.13.8) with ESMTP id n0K8wiWs021187 for ; Tue, 20 Jan 2009 09:58:48 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <497376DE.1030302@t-online.de> <874ozvsisy.fsf@xs4all.nl> <1LOtU4-0rd5O40@fwd04.aul.t-online.de> <4974E7AF.9030001@t-online.de> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 20 Jan 2009 10:00:36 +0100 In-Reply-To: <4974E7AF.9030001@t-online.de> (Christian Franke's message of "Mon, 19 Jan 2009 21:50:55 +0100") Message-ID: <87zlhmqrm3.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] (ata.mod) Fix ATAPI protocol X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2009 08:58:52 -0000 Christian Franke writes: > Christian Franke wrote: >> Marco Gerards wrote: >> >>> Christian Franke <...> writes: >>> >>> >>>> This patch fixes the data I/O protocol of the ATA PACKET command. >>>> >>>> The current implementation does not read the byte count >>>> registers. ATAPI read may not work if the drive sends the data in >>>> more than one block. >>>> >>>> In conjunction with my recent SCSI blocksize patch, ATAPI CD/DVD >>>> drives should now work. >>>> >>>> >>> Sorry for not commenting on many things on this list. I am too busy >>> to check all this. >> >> N.P. >> >> Meantime, I have tested the SCSI and ATAPI fixes on several PC. If there >> are no further comments, I will commit these soon. >> >> > > Committed, plus an additional wait in grub_atapi_identify. Great! :-) > Open issues: > - grub_pio_read/write() check the ERR bit without ensuring !BSY. > - ata_read fails if (batch % size) == 0. > - ata_write does not work at all, it uses the read cmd. grub_ata_write does not use the read cmd, or do you mean indirectly? In that case, where does it use the read command? -- Marco