All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Meyering <meyering@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Sujith.Manoharan@atheros.com, linville@tuxdriver.com
Subject: [PATCH] ath9k: add harmlessly-omitted braces
Date: Sat, 23 Aug 2008 08:49:09 +0200
Date: Sat, 23 Aug 2008 08:49:52 +0200	[thread overview]
Message-ID: <87zln4rzce.fsf@rho.meyering.net> (raw)


---
Alternatively, you could remove the nowadays-useless
"if-before-kfree" test and leave the sometimes-redundant
assignment as-is: unconditional.

 drivers/net/wireless/ath9k/main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath9k/main.c b/drivers/net/wireless/ath9k/main.c
index 2888778..21bef29 100644
--- a/drivers/net/wireless/ath9k/main.c
+++ b/drivers/net/wireless/ath9k/main.c
@@ -1056,9 +1056,10 @@ void ath_tx_complete(struct ath_softc *sc, struct sk_buff *skb,
 	if (tx_info->flags & IEEE80211_TX_CTL_NO_ACK ||
 		tx_info->flags & IEEE80211_TX_STAT_TX_FILTERED) {
 		/* free driver's private data area of tx_info */
-		if (tx_info->driver_data[0] != NULL)
+		if (tx_info->driver_data[0] != NULL) {
 			kfree(tx_info->driver_data[0]);
 			tx_info->driver_data[0] = NULL;
+		}
 	}

 	if (tx_status->flags & ATH_TX_BAR) {
--
1.6.0.90.g436ed

             reply	other threads:[~2008-08-23  6:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-23  6:49 Jim Meyering [this message]
2008-08-23 10:02 ` [PATCH] ath9k: add harmlessly-omitted braces Marcel Holtmann
2008-08-23 10:25   ` [PATCH] ath9k: remove useless if-before-kfree; correct misleading indentation Jim Meyering
2008-08-23 11:03     ` Marcel Holtmann
2008-08-23 11:28       ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zln4rzce.fsf@rho.meyering.net \
    --to=meyering@redhat.com \
    --cc=Sujith.Manoharan@atheros.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.