From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Iqv0q-00043a-Hf for mharc-grub-devel@gnu.org; Sat, 10 Nov 2007 13:24:56 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iqv0o-0003zT-JI for grub-devel@gnu.org; Sat, 10 Nov 2007 13:24:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iqv0m-0003uO-BG for grub-devel@gnu.org; Sat, 10 Nov 2007 13:24:53 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iqv0l-0003tg-QG for grub-devel@gnu.org; Sat, 10 Nov 2007 13:24:51 -0500 Received: from smtp-vbr15.xs4all.nl ([194.109.24.35]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iqv0k-0003Sz-Vq for grub-devel@gnu.org; Sat, 10 Nov 2007 13:24:51 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr15.xs4all.nl (8.13.8/8.13.8) with ESMTP id lAAIOnX8042093 for ; Sat, 10 Nov 2007 19:24:50 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <4735BA5D.4020800@nic.fi> Mail-Copies-To: mgerards@xs4all.nl Date: Sat, 10 Nov 2007 19:25:23 +0100 In-Reply-To: <4735BA5D.4020800@nic.fi> (Vesa =?iso-8859-1?Q?J=E4=E4skel=E4?= =?iso-8859-1?Q?inen's?= message of "Sat, 10 Nov 2007 16:04:13 +0200") Message-ID: <87zlxmarfw.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [patch] Fix for vga terminal X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2007 18:24:55 -0000 Vesa J=E4=E4skel=E4inen writes: Hi Vesa, > Here is patch for fixing vga terminal. At least it worked fine on qemu. > Now it uses only font system to get fonts so you need to load font > module and use fonts. See gfxterm section on the wiki on how to do that. > > I had to edit patch by hand as 64bit patch is still pending and I need > that to compile my codes. But it should still apply nicely to current CVS. Great! Thanks for fixing this! [...] > +2007-11-10 Vesa Jaaskelainen > + > + * conf/i386-pc.rmk (pkgdata_MODULES): Added vga.mod. > + (vga_mod_SOURCES): Added. > + (vga_mod_CFLAGS): Likewise. > + (vga_mod_LDFLAGS): Likewise. > + > + * term/i386/pc/vga.c (get_map_mask): Switch order of arguments in > + grub_outb() calls. > + (set_map_mask): Likewise. > + (set_read_map): Likewise. > + (set_read_address): Likewise. > + (vga_font): Removed variable. > + (get_vga_glyph): Removed function. > + (invalidate_char): Likewise. > + (write_char): Changed to use grub_font_get_glyph() for font > + information. > + (grub_vga_putchar): Likewise. > + (grub_vga_getcharwidth): Likewise. This looks good to me. Feel free to commit this! :-) -- Marco