All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] SCSI: Update ASC list and make it const
@ 2007-02-28 17:37 Martin K. Petersen
  2007-02-28 17:45 ` Daniel J. Priem
  0 siblings, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2007-02-28 17:37 UTC (permalink / raw)
  To: linux-scsi


Add missing additional sense code and provide pointer to upstream
reference (from Doug Gilbert).

Add missing const (from Michael Tokarev).

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

--- 

 constants.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletion(-)


Index: scsi-misc-2.6/drivers/scsi/constants.c
===================================================================
--- scsi-misc-2.6.orig/drivers/scsi/constants.c
+++ scsi-misc-2.6/drivers/scsi/constants.c
@@ -404,7 +404,11 @@ struct error_info {
 	const char * text;
 };
 
-static struct error_info additional[] =
+/*
+ * The canonical list of T10 Additional Sense Codes is available at:
+ * http://www.t10.org/lists/asc-num.txt
+ */
+static const struct error_info additional[] =
 {
 	{0x0000, "No additional sense information"},
 	{0x0001, "Filemark detected"},
@@ -708,6 +712,7 @@ static struct error_info additional[] =
 
 	{0x2F00, "Commands cleared by another initiator"},
 	{0x2F01, "Commands cleared by power loss notification"},
+	{0x2F02, "Commands cleared by device server"},
 
 	{0x3000, "Incompatible medium installed"},
 	{0x3001, "Cannot read medium - unknown format"},

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] SCSI: Update ASC list and make it const
  2007-02-28 17:37 [PATCH] SCSI: Update ASC list and make it const Martin K. Petersen
@ 2007-02-28 17:45 ` Daniel J. Priem
  2007-02-28 18:14   ` Martin K. Petersen
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel J. Priem @ 2007-02-28 17:45 UTC (permalink / raw)
  To: linux-scsi

"Martin K. Petersen" <martin.petersen@oracle.com> writes:
> + * The canonical list of T10 Additional Sense Codes is available at:
> + * http://www.t10.org/lists/asc-num.txt+ */

Please do a

- * http://www.t10.org/lists/asc-num.txt+ */
+ * http://www.t10.org/lists/asc-num.txt */

its a typo.
Regards
Daniel

-- 
 .''`.
 : :' :      Daniel J. Priem
 `. `'       http://flexserv.de
   `-        


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] SCSI: Update ASC list and make it const
  2007-02-28 17:45 ` Daniel J. Priem
@ 2007-02-28 18:14   ` Martin K. Petersen
  2007-02-28 18:56     ` Daniel J. Priem
  0 siblings, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2007-02-28 18:14 UTC (permalink / raw)
  To: Daniel J Priem; +Cc: linux-scsi

>>>>> "Daniel" == Daniel J Priem <daniel@flexserv.de> writes:

Daniel> - * http://www.t10.org/lists/asc-num.txt+ */ 
Daniel> + * http://www.t10.org/lists/asc-num.txt */

Daniel> its a typo.  

The diff looks fine both here and in the archives.  Maybe your mailer
mangled it?

-- 
Martin K. Petersen	Oracle Linux Engineering


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] SCSI: Update ASC list and make it const
  2007-02-28 18:14   ` Martin K. Petersen
@ 2007-02-28 18:56     ` Daniel J. Priem
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel J. Priem @ 2007-02-28 18:56 UTC (permalink / raw)
  To: linux-scsi

"Martin K. Petersen" <martin.petersen@oracle.com> writes:

>>>>>> "Daniel" == Daniel J Priem <daniel@flexserv.de> writes:
>
> Daniel> - * http://www.t10.org/lists/asc-num.txt+ */ 
> Daniel> + * http://www.t10.org/lists/asc-num.txt */
>
> Daniel> its a typo.  
>
> The diff looks fine both here and in the archives.  Maybe your mailer
> mangled it?
Yes. you are right. i crosschecked against
http://permalink.gmane.org/gmane.linux.scsi/30188 ...

-- 
 .''`.
 : :' :      Daniel J. Priem
 `. `'       http://flexserv.de
   `-        


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-02-28 18:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-28 17:37 [PATCH] SCSI: Update ASC list and make it const Martin K. Petersen
2007-02-28 17:45 ` Daniel J. Priem
2007-02-28 18:14   ` Martin K. Petersen
2007-02-28 18:56     ` Daniel J. Priem

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.