All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Smith <danms@us.ibm.com>
To: Ewan Mellor <ewan@xensource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH][RESEND] Fix stale-state issue with 'xm dom{id, name}'
Date: Sat, 01 Oct 2005 08:33:06 -0700	[thread overview]
Message-ID: <87zmptfe19.fsf@us.ibm.com> (raw)
In-Reply-To: <20051001105416.GB11498@uk.xensource.com> (Ewan Mellor's message of "Sat, 1 Oct 2005 11:54:17 +0100")


EM> The thing is, it solves the problem by making sure that SrvDomain
EM> can cope with stale domains being returned by XendDomain, but I
EM> _really_ don't want XendDomain to be returning stale information
EM> in the first place.

I agree.  I recently submitted a patch that would cause XendDomainInfo
to destroy itself whenever it realized that it was stale.  Christian
didn't like the idea of random places modifying the Xend state.  So,
in this patch, I just handled the stale state instead of returning the
bogus information, and without modifying the state itself.

EM> I've been trying to decide how easy it would be to fix the
EM> underlying problem -- if it's going to take a long time, then I'll
EM> apply your patch as a workaround, but I hope to solve the problem
EM> more definitively.

I think the solution (or best fix) is to standardize on the fact that
we always update domain information right before we return it, and
purge that information if needed.  I think that "xm list" triggers
this somewhere deep inside xend, as I can always purge the stale data
by running an "xm list".  This tells me that some async signals aren't
always being sent to clean up, which means "xm list" has to trigger
it.  I *think* Anthony had a comment about polling being necessary in
this case for some reason, so perhaps he can chime in and explain.

Thanks Ewan!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@us.ibm.com

  reply	other threads:[~2005-10-01 15:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-30 16:54 [PATCH][RESEND] Fix stale-state issue with 'xm dom{id, name}' Dan Smith
2005-10-01 10:54 ` Ewan Mellor
2005-10-01 15:33   ` Dan Smith [this message]
2005-10-01 19:40     ` Anthony Liguori
2005-10-04  7:36 ` Ewan Mellor
2005-10-04 13:41   ` Dan Smith
2005-10-04 17:35   ` Dan Smith
2005-10-04 23:14     ` Ewan Mellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zmptfe19.fsf@us.ibm.com \
    --to=danms@us.ibm.com \
    --cc=ewan@xensource.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.