From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DVkxH-0006lV-A1 for mharc-grub-devel@gnu.org; Wed, 11 May 2005 02:44:27 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DVkxC-0006g5-AO for grub-devel@gnu.org; Wed, 11 May 2005 02:44:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DVkx7-0006cm-U2 for grub-devel@gnu.org; Wed, 11 May 2005 02:44:18 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DVkx7-0006YF-CA for grub-devel@gnu.org; Wed, 11 May 2005 02:44:17 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DVl26-0006mY-AB for grub-devel@gnu.org; Wed, 11 May 2005 02:49:26 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 63FCB8DA2 for ; Wed, 11 May 2005 08:37:28 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 10719-05 for ; Wed, 11 May 2005 08:37:27 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 455E68393 for ; Wed, 11 May 2005 08:37:27 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id ECF77C045 for ; Wed, 11 May 2005 08:37:26 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050510013936.GA20230@miracle> <873bsvq7ss.fsf@student.han.nl> From: Marco Gerards Date: Wed, 11 May 2005 08:37:27 +0200 In-Reply-To: (Hollis Blanchard's message of "Tue, 10 May 2005 17:34:02 -0500") Message-ID: <87zmv2clp4.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [ppc] [patch] more cleanups X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2005 06:44:24 -0000 Hollis Blanchard writes: >>> /* Where grub-mkimage places the core modules in memory. */ >>> -#define GRUB_IEEE1275_MODULE_BASE 0x0300000 >>> +#define GRUB_IEEE1275_MODULE_BASE 0x00300000 >> >> Huh? Can you explain this? I would even prefer: >> >> #define GRUB_IEEE1275_MODULE_BASE 0x300000 > > What is to explain? The address has 7 chars in it when it should have > 8. The leading zeroes make it easier to read. Ok, that makes sense. >> Does loading linux with an initrd still work? > > I said it did... I must have missed that, sorry. Feel free to commit your patch. Thanks, Marco