From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DEt3N-0007of-Ez for mharc-grub-devel@gnu.org; Fri, 25 Mar 2005 12:57:01 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DEt38-0007f3-9c for grub-devel@gnu.org; Fri, 25 Mar 2005 12:56:48 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DEt2y-0007a1-Mb for grub-devel@gnu.org; Fri, 25 Mar 2005 12:56:38 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DEt2y-0007Ze-Gy for grub-devel@gnu.org; Fri, 25 Mar 2005 12:56:36 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DEsne-0006jW-7y for grub-devel@gnu.org; Fri, 25 Mar 2005 12:40:46 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id C1E3E96E6 for ; Fri, 25 Mar 2005 18:40:45 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 07552-08 for ; Fri, 25 Mar 2005 18:40:43 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id BF1A6919E for ; Fri, 25 Mar 2005 18:40:43 +0100 (CET) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 83924C048 for ; Fri, 25 Mar 2005 18:40:43 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050324030054.GA21271@miracle> <87wtrwvi09.fsf@student.han.nl> <760297805a8bd800c27a04d97b275c27@penguinppc.org> From: Marco Gerards Date: Fri, 25 Mar 2005 18:40:44 +0100 In-Reply-To: <760297805a8bd800c27a04d97b275c27@penguinppc.org> (Hollis Blanchard's message of "Fri, 25 Mar 2005 08:58:42 -0600") Message-ID: <87zmwrsjxf.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [patch] PPC build fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2005 17:56:59 -0000 Hollis Blanchard writes: [...] > Because these commands need to be accessible from grub-emu (that is > how you quit). Oh, right. >>> * include/grub/powerpc/ieee1275/init.h: Remove inaccurate >>> comment. >> >> Can you change the comment to something sane? > > include/grub/i386/pc/init.h has no comment, and I don't know how to > describe this anyways: > void cmain (uint32_t r3, uint32_t r4, uint32_t r5); > void grub_ofdisk_init (void); > void grub_console_init (void); > "A tiny bit of miscellaneous stuff"? "Things related to booting"? Ok, just remove it. You are right again. :) >>> * util/powerpc/ieee1275/misc.c (grub_reboot): New function. >>> (grub_halt): Likewise. >> >> Isn't this just a completely new file? > > Er, yes, sorry. :) Can you change these two lines to this: * util/powerpc/ieee1275/misc.c: New file If you do this, you could commit the patch. I can also do it if you want. After this we can concentrate on getting that boot-path patch committed. I will fix the initrd problem this weekend. Thanks, Marco