From: Philippe Troin <phil@fifi.org>
To: Willy Tarreau <willy@w.ods.org>
Cc: linux-kernel@vger.kernel.org,
Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux@syskonnect.de
Subject: Re: 2.4.29 sk98lin patch for Asus K8W SE Deluxe
Date: 03 Mar 2005 17:06:10 -0800 [thread overview]
Message-ID: <87zmxkrzi5.fsf@ceramic.fifi.org> (raw)
In-Reply-To: <20050303075220.GG30106@alpha.home.local>
Willy Tarreau <willy@w.ods.org> writes:
> On Wed, Mar 02, 2005 at 02:00:30PM -0800, Philippe Troin wrote:
>
> > + /* Asus K8V Se Deluxe bugfix. Correct VPD content */
> > + /* MBo April 2004 */
> > + if( ((unsigned char)pAC->vpd.vpd_buf[0x3f] == 0x38) &&
> > + ((unsigned char)pAC->vpd.vpd_buf[0x40] == 0x3c) &&
> > + ((unsigned char)pAC->vpd.vpd_buf[0x41] == 0x45) ) {
> > + printk("sk98lin : humm... Asus mainboard with buggy VPD ? correcting data.\n");
> ^^^^^
> Please, could you put some KERN_XXX here to avoid a buggy message level ?
Yes, of course.
Phil.
Signed-Off-By: Philippe Troin <phil@fifi.rog>
diff -ruN linux-2.4.29.orig/drivers/net/sk98lin/skvpd.c linux-2.4.29/drivers/net/sk98lin/skvpd.c
--- linux-2.4.29.orig/drivers/net/sk98lin/skvpd.c Wed Apr 14 06:05:30 2004
+++ linux-2.4.29/drivers/net/sk98lin/skvpd.c Mon Feb 21 02:03:00 2005
@@ -466,6 +466,15 @@
pAC->vpd.vpd_size = vpd_size;
+ /* Asus K8V Se Deluxe bugfix. Correct VPD content */
+ /* MBo April 2004 */
+ if( ((unsigned char)pAC->vpd.vpd_buf[0x3f] == 0x38) &&
+ ((unsigned char)pAC->vpd.vpd_buf[0x40] == 0x3c) &&
+ ((unsigned char)pAC->vpd.vpd_buf[0x41] == 0x45) ) {
+ printk(KERN_INFO "sk98lin : humm... Asus mainboard with buggy VPD ? correcting data.\n");
+ (unsigned char)pAC->vpd.vpd_buf[0x40] = 0x38;
+ }
+
/* find the end tag of the RO area */
if (!(r = vpd_find_para(pAC, VPD_RV, &rp))) {
SK_DBG_MSG(pAC, SK_DBGMOD_VPD, SK_DBGCAT_ERR | SK_DBGCAT_FATAL,
prev parent reply other threads:[~2005-03-04 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 22:00 2.4.29 sk98lin patch for Asus K8W SE Deluxe Philippe Troin
2005-03-03 7:52 ` Willy Tarreau
2005-03-04 1:06 ` Philippe Troin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmxkrzi5.fsf@ceramic.fifi.org \
--to=phil@fifi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@syskonnect.de \
--cc=marcelo.tosatti@cyclades.com \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.