All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Dietsche <olaf.dietsche#list.linux-kernel@t-online.de>
To: Andrew Morton <akpm@digeo.com>
Cc: Ben Clifford <benc@hawaga.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: programming for preemption (was: [PATCH] 2.5.46: access permission filesystem)
Date: Mon, 11 Nov 2002 18:45:33 +0100	[thread overview]
Message-ID: <87znsgov9e.fsf@goat.bogus.local> (raw)
In-Reply-To: 3DCF1593.CB9C7AA4@digeo.com

Andrew Morton <akpm@digeo.com> writes:

> Olaf Dietsche wrote:
>> 
>> Ben Clifford <benc@hawaga.org.uk> writes:
>> 
>> > I still get those stack traces, though...
>> 
>> I retested with CONFIG_PREEMPT=y and now I get those stack traces,
>> too. So, it seems my code is not preempt safe.
>> 
>
> It's not that your code is unsafe with preemption.  It's just that
> CONFIG_PREEMPT=y turns on the debugging infrastructure which allows
> us to detect things like calling kmalloc(GFP_KERNEL) inside spinlock.

Thanks for this hint. So this means kmalloc(GFP_KERNEL) inside
spinlock is not necessarily dangerous, but should be avoided if
possible? Is using a semaphore better than using spinlocks? Is
there a list of dos and don'ts for preempt kernels beside
Documentation/preempt-locking.txt?

And btw, who is "us"?

Regards, Olaf.

  reply	other threads:[~2002-11-11 17:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-05 15:51 [PATCH] 2.5.46: access permission filesystem Olaf Dietsche
2002-11-10  1:33 ` Ben Clifford
2002-11-10 15:56   ` Olaf Dietsche
2002-11-11  0:11     ` Ben Clifford
2002-11-11  1:57       ` Olaf Dietsche
2002-11-11  2:27         ` Andrew Morton
2002-11-11 17:45           ` Olaf Dietsche [this message]
2002-11-11 18:17             ` programming for preemption (was: [PATCH] 2.5.46: accesspermission filesystem) Andrew Morton
2002-11-11 23:19               ` Olaf Dietsche
2002-11-11 18:23             ` programming for preemption (was: [PATCH] 2.5.46: access permission filesystem) Roland Dreier
2002-11-11 23:58             ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87znsgov9e.fsf@goat.bogus.local \
    --to=olaf.dietsche#list.linux-kernel@t-online.de \
    --cc=akpm@digeo.com \
    --cc=benc@hawaga.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.