From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Zhigang Lu <zlu@ezchip.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 04/12] eal: allow empty compile time flags
Date: Thu, 09 Jul 2015 02:46:17 +0200 [thread overview]
Message-ID: <8813269.8bcvtOYP9E@xps13> (raw)
In-Reply-To: <1436172698-21749-5-git-send-email-zlu@ezchip.com>
2015-07-06 16:51, Zhigang Lu:
> The rte_cpu_check_supported() code breaks with a "comparison is always
> false due to limited range of data type" when the compile_time_flags[]
> array is empty. Assigning the array dimension to a local variable
> apparently solves this.
How is it related to the title "allow empty compile time flags"?
> - unsigned i;
> + unsigned count = RTE_DIM(compile_time_flags), i;
> int ret;
Please define a "const unsigned count =" here to improve readability.
> - for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++) {
> + for (i = 0; i < count; i++) {
next prev parent reply other threads:[~2015-07-09 0:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 8:51 [PATCH v3 00/12] Introducing the TILE-Gx platform Zhigang Lu
2015-07-06 8:51 ` [PATCH v3 01/12] test: limit x86 cpuflags checks to x86 builds Zhigang Lu
2015-07-06 10:53 ` Bruce Richardson
2015-07-07 8:21 ` Tony Lu
2015-07-06 8:51 ` [PATCH v3 02/12] hash: fix compilation on non-X86 platforms Zhigang Lu
2015-07-06 11:15 ` Bruce Richardson
2015-07-07 8:24 ` Tony Lu
2015-07-07 14:52 ` Sanford, Robert
2015-07-08 8:21 ` Tony Lu
2015-07-06 8:51 ` [PATCH v3 03/12] hash: check SSE flags only on x86 builds Zhigang Lu
2015-07-06 15:32 ` Bruce Richardson
2015-07-06 8:51 ` [PATCH v3 04/12] eal: allow empty compile time flags Zhigang Lu
2015-07-06 15:33 ` Bruce Richardson
2015-07-09 0:46 ` Thomas Monjalon [this message]
2015-07-09 4:20 ` Tony Lu
2015-07-09 6:49 ` damu
2015-07-06 8:51 ` [PATCH v3 05/12] config: remove RTE_LIBNAME definition Zhigang Lu
2015-07-06 15:34 ` Bruce Richardson
2015-07-06 8:51 ` [PATCH v3 06/12] memzone: refactor rte_memzone_reserve() variants Zhigang Lu
2015-07-09 0:51 ` Thomas Monjalon
2015-07-06 8:51 ` [PATCH v3 07/12] memzone: allow multiple pagesizes to be requested Zhigang Lu
2015-07-06 8:51 ` [PATCH v3 08/12] mempool: allow config override on element alignment Zhigang Lu
2015-07-06 15:37 ` Bruce Richardson
2015-07-07 9:15 ` Tony Lu
2015-07-07 10:10 ` Bruce Richardson
2015-07-06 8:51 ` [PATCH v3 09/12] tile: add page sizes for TILE-Gx/Mx platforms Zhigang Lu
2015-07-06 8:51 ` [PATCH v3 10/12] tile: initial TILE-Gx support Zhigang Lu
2015-07-06 8:51 ` [PATCH v3 11/12] tile: Add TILE-Gx mPIPE poll mode driver Zhigang Lu
2015-07-06 8:51 ` [PATCH v3 12/12] maintainers: claim responsibility for TILE-Gx platform Zhigang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8813269.8bcvtOYP9E@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=zlu@ezchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.