From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH 4 of 7] xenpaging: remove return values from functions that can not fail
Date: Thu, 31 Mar 2011 19:36:21 +0200 [thread overview]
Message-ID: <8825c216096a80e5590c.1301592981@localhost> (raw)
In-Reply-To: <patchbomb.1301592977@localhost>
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1301591599 -7200
# Node ID 8825c216096a80e5590ce075da273eeb06c1e7aa
# Parent cd35892de8ff2388aa46e3768393f217a3c63521
xenpaging: remove return values from functions that can not fail
get_request() and put_response() can not fail, remove return value
and update calling functions.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r cd35892de8ff -r 8825c216096a tools/xenpaging/xenpaging.c
--- a/tools/xenpaging/xenpaging.c Thu Mar 31 19:12:50 2011 +0200
+++ b/tools/xenpaging/xenpaging.c Thu Mar 31 19:13:19 2011 +0200
@@ -297,7 +297,7 @@
return -1;
}
-static int get_request(mem_event_t *mem_event, mem_event_request_t *req)
+static void get_request(mem_event_t *mem_event, mem_event_request_t *req)
{
mem_event_back_ring_t *back_ring;
RING_IDX req_cons;
@@ -316,11 +316,9 @@
back_ring->sring->req_event = req_cons + 1;
mem_event_ring_unlock(mem_event);
-
- return 0;
}
-static int put_response(mem_event_t *mem_event, mem_event_response_t *rsp)
+static void put_response(mem_event_t *mem_event, mem_event_response_t *rsp)
{
mem_event_back_ring_t *back_ring;
RING_IDX rsp_prod;
@@ -339,8 +337,6 @@
RING_PUSH_RESPONSES(back_ring);
mem_event_ring_unlock(mem_event);
-
- return 0;
}
static int xenpaging_evict_page(xenpaging_t *paging,
@@ -400,9 +396,7 @@
int ret;
/* Put the page info on the ring */
- ret = put_response(&paging->mem_event, rsp);
- if ( ret != 0 )
- goto out;
+ put_response(&paging->mem_event, rsp);
/* Notify policy of page being paged in */
if ( notify_policy )
@@ -612,12 +606,7 @@
while ( RING_HAS_UNCONSUMED_REQUESTS(&paging->mem_event.back_ring) )
{
- rc = get_request(&paging->mem_event, &req);
- if ( rc != 0 )
- {
- ERROR("Error getting request");
- goto out;
- }
+ get_request(&paging->mem_event, &req);
/* Check if the page has already been paged in */
if ( test_and_clear_bit(req.gfn, paging->bitmap) )
next prev parent reply other threads:[~2011-03-31 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 17:36 [PATCH 0 of 7] xenpaging updates Olaf Hering
2011-03-31 17:36 ` [PATCH 1 of 7] xenpaging: correct dropping pages to avoid full ring buffer Olaf Hering
2011-03-31 17:36 ` [PATCH 2 of 7] xenpaging: do not bounce p2mt to xenpaging Olaf Hering
2011-03-31 17:36 ` [PATCH 3 of 7] xenpaging: remove srand call Olaf Hering
2011-03-31 17:48 ` Patrick Colp
2011-03-31 18:17 ` Olaf Hering
2011-03-31 18:37 ` Patrick Colp
2011-04-01 8:20 ` Olaf Hering
2011-04-02 19:29 ` Patrick Colp
2011-03-31 17:36 ` Olaf Hering [this message]
2011-03-31 17:36 ` [PATCH 5 of 7] xenpaging: catch xc_mem_paging_resume errors Olaf Hering
2011-03-31 17:36 ` [PATCH 6 of 7] xenpaging: pass integer to xenpaging_populate_page Olaf Hering
2011-03-31 17:36 ` [PATCH 7 of 7] xenpaging: start xenpaging via config option Olaf Hering
2011-04-01 10:24 ` [PATCH 0 of 7] xenpaging updates Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8825c216096a80e5590c.1301592981@localhost \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.