From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94F0DCED609 for ; Wed, 9 Oct 2024 06:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:References: In-Reply-To:Message-ID:Cc:To:From:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=i2NbNwgoswja3kahkmKRlzt2TLLoNt26jUjVHXGEErk=; b=ree0Esk5dSntU5qYsiHp0bM+OU b8j35Y8kNShbjqB4bWzWBBPEsYlPrbq60LizAG6TKaIb1hlEJcZfcmCyqp0WHNcL4BghTVIB8Yr31 +ip/h9g6Z3pxiLyAqxgioIQAkE7BliVL7KDOl/NS3PiDfst0/4dIXQraeaotBUjmFgv8sk/RnudI3 0GvSAPscSDkEHLj6eif7Mgs3BhFfYkugjJBjckjqn4QoNVVai5pv/4t2XsJIyXvfrTIi0KNZGvU4U MB0CBvuk1DiBX60mjdVQRC+W50At9otGlwsFieffIndnuypldIPDacTMGoOh11Ns6x4XF7272izSE sXFZWS2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syPnr-0000000825Q-3E5j; Wed, 09 Oct 2024 06:04:07 +0000 Received: from lithops.sigma-star.at ([195.201.40.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syPno-0000000822h-2bTD for linux-mtd@lists.infradead.org; Wed, 09 Oct 2024 06:04:06 +0000 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 44441294730; Wed, 9 Oct 2024 08:03:53 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SDQz2X6cGIl0; Wed, 9 Oct 2024 08:03:52 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 835172A87E7; Wed, 9 Oct 2024 08:03:52 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ay6qInBW_KBx; Wed, 9 Oct 2024 08:03:52 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 51353294730; Wed, 9 Oct 2024 08:03:52 +0200 (CEST) Date: Wed, 9 Oct 2024 08:03:52 +0200 (CEST) From: Richard Weinberger To: chengzhihao1 Cc: Benedikt Spranger , linux-kernel , linux-mtd Message-ID: <883601802.30668.1728453832223.JavaMail.zimbra@nod.at> In-Reply-To: <0840be30-63bc-449d-a9a4-c4e6b54c8885@huawei.com> References: <20241008133342.1937674-1-b.spranger@linutronix.de> <0840be30-63bc-449d-a9a4-c4e6b54c8885@huawei.com> Subject: Re: [PATCH 1/1] ubifs: Try to recover from missing znode MIME-Version: 1.0 X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF131 (Linux)/8.8.12_GA_3809) Thread-Topic: ubifs: Try to recover from missing znode Thread-Index: I2FbrW4jE5dKP7zIOPm0UuQ/GQmFIA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_230404_833270_E2BDB97C X-CRM114-Status: UNSURE ( 7.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org LS0tLS0gVXJzcHLDvG5nbGljaGUgTWFpbCAtLS0tLQo+IFZvbjogImNoZW5nemhpaGFvMSIgPGNo ZW5nemhpaGFvMUBodWF3ZWkuY29tPgo+IEFuOiAiQmVuZWRpa3QgU3ByYW5nZXIiIDxiLnNwcmFu Z2VyQGxpbnV0cm9uaXguZGU+LCAibGludXgta2VybmVsIiA8bGludXgta2VybmVsQHZnZXIua2Vy bmVsLm9yZz4KPiBDQzogImxpbnV4LW10ZCIgPGxpbnV4LW10ZEBsaXN0cy5pbmZyYWRlYWQub3Jn PiwgInJpY2hhcmQiIDxyaWNoYXJkQG5vZC5hdD4KPiBHZXNlbmRldDogTWl0dHdvY2gsIDkuIE9r dG9iZXIgMjAyNCAwNDoyMzowMgo+IEJldHJlZmY6IFJlOiBbUEFUQ0ggMS8xXSB1YmlmczogVHJ5 IHRvIHJlY292ZXIgZnJvbSBtaXNzaW5nIHpub2RlCgo+IOWcqCAyMDI0LzEwLzggMjE6MzMsIEJl bmVkaWt0IFNwcmFuZ2VyIOWGmemBkzoKPj4gQWZ0ZXIgcG93ZXJjdXQgb24gYSBzeXN0ZW0gdXNp bmcgdWJpZnMgbW91bnRpbmcgZmFpbGVkOgo+PiAKPj4gMjAyNC0wOS0zMFQxMjozODoyNi44ODA0 ODcrMDI6MDAgc29uamEga2VybmVsOiBVQklGUyBlcnJvciAodWJpMDowIHBpZCAyMTc4KToKPj4g dWJpZnNfcmVhZF9ub2RlIFt1Ymlmc106IGJhZCBub2RlIHR5cGUgKDI1NSBidXQgZXhwZWN0ZWQg OSkKPj4gMjAyNC0wOS0zMFQxMjozODoyNi44ODA1MDYrMDI6MDAgc29uamEga2VybmVsOiBVQklG UyBlcnJvciAodWJpMDowIHBpZCAyMTc4KToKPj4gdWJpZnNfcmVhZF9ub2RlIFt1Ymlmc106IGJh ZCBub2RlIGF0IExFQiAxMDM6NDY5MjAsIExFQiBtYXBwaW5nIHN0YXR1cyAwCj4+IDIwMjQtMDkt MzBUMTI6Mzg6MjYuODgwNTA5KzAyOjAwIHNvbmphIGtlcm5lbDogTm90IGEgbm9kZSwgZmlyc3Qg MjQgYnl0ZXM6Cj4+IDIwMjQtMDktMzBUMTI6Mzg6MjYuODgwNTEwKzAyOjAwIHNvbmphIGtlcm5l bDogMDAwMDAwMDA6IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4+IGZmIGZmIGZmIGZmIGZmIGZm IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4+IC4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Lgo+PiAKPj4gV2hpbGUgdHJhdmVyc2luZyBvdmVyIHpicmFuY2hlcyBkdXJpbmcgdGhlIGpvdXJu YWwgcmVwbGF5IG9uZSB6YnJhbmNoCj4+IHBvaW50cyB0byBhIHpub2RlLCB3aGljaCB3YXMgbm90 IHdyaXR0ZW4gdG8gdGhlIGZsYXNoIGFuZCB0aGVyZWZvcmUgdGhlCj4+IGZsYXNoIGlzIGVtcHR5 Lgo+IAo+IFVCSUZTIGd1YXJhbnRlZXMgdHdvIHRoaW5ncyBmb3Igem5vZGVzOgo+IDEpIGFsbCBp bmRleCBub2RlcyhpbiBjb21taXQgc2VxIE4pIGFyZSB3cml0dGVuIG9uIGZsYXNoIGJlZm9yZSBt YXN0ZXIKPiBub2Rlcyhmb3IgY29tbWl0IHNlcSBOKSBhcmUgd3JpdHRlbi4KPiAyKSBhbGwgaW5k ZXggbm9kZXMoaW4gY29tbWl0IHNlcSBOKSB3b24ndCBiZSBlcmFzZWQgZnJvbSBmbGFzaCBiZWZv cmUKPiBtYXN0ZXIgbm9kZXMoZm9yIGNvbW1pdCBzZXEgTisxKSBhcmUgd3JpdHRlbi4KPiBTbywg SSBkb24ndCB1bmRlcnN0YW5kIHRoYXQgd2h5IHpub2RlcyBub3QgZXhpc3QgZHVyaW5nIGpvdXJu YWwgcmVwbGF5aW5nPwoKSW4gYWRkaXRpb24gdG8gdGhhdCwgaXMganVzdCBvbmUgem5vZGUgbWlz c2luZyBvciBhcmUgbGFyZ2VyIHBhcnRzIG9mIHRoZSBmbGFzaAplbXB0eT8KClRoYW5rcywKLy9y aWNoYXJkCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 231241E519 for ; Wed, 9 Oct 2024 06:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.201.40.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728454191; cv=none; b=NK8ioYaH8GNUG4BjZ1gkf+Ltv6dhaWovoF2+g5AQulh3N3xF3hHmDR6qmJW+xNNtxIrqBaJo5n2VkxvYMSau71o0ZO1pYoJKPgB/a/wD+dFYvu5QWWDnr0Rz5xgKOglu72gdkVb7mh4Sghhw/rgbj2mzKILT7bWIUA/tggTC0SU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728454191; c=relaxed/simple; bh=2C/DYVTbW7dN24xicSg+1V6MJky+mekZnqgt+79cJtw=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=g1rvml+/aw3kkHrSWvjRCFR8OptO8zp7y09S82AngW7tx96G/1qbFwN2bN4+sn4VO7XakXubm5mn/jfsmtDpAFjBZahWvZvDavgKNGDu6qBHESGM/LlhR+JzMvdGLkmHTVRnZ/tp76pAZN+m07CzqlZiF2lL5QSw5LcCnmsYgr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at; spf=fail smtp.mailfrom=nod.at; arc=none smtp.client-ip=195.201.40.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nod.at Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 44441294730; Wed, 9 Oct 2024 08:03:53 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SDQz2X6cGIl0; Wed, 9 Oct 2024 08:03:52 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 835172A87E7; Wed, 9 Oct 2024 08:03:52 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ay6qInBW_KBx; Wed, 9 Oct 2024 08:03:52 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 51353294730; Wed, 9 Oct 2024 08:03:52 +0200 (CEST) Date: Wed, 9 Oct 2024 08:03:52 +0200 (CEST) From: Richard Weinberger To: chengzhihao1 Cc: Benedikt Spranger , linux-kernel , linux-mtd Message-ID: <883601802.30668.1728453832223.JavaMail.zimbra@nod.at> In-Reply-To: <0840be30-63bc-449d-a9a4-c4e6b54c8885@huawei.com> References: <20241008133342.1937674-1-b.spranger@linutronix.de> <0840be30-63bc-449d-a9a4-c4e6b54c8885@huawei.com> Subject: Re: [PATCH 1/1] ubifs: Try to recover from missing znode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF131 (Linux)/8.8.12_GA_3809) Thread-Topic: ubifs: Try to recover from missing znode Thread-Index: I2FbrW4jE5dKP7zIOPm0UuQ/GQmFIA== ----- Urspr=C3=BCngliche Mail ----- > Von: "chengzhihao1" > An: "Benedikt Spranger" , "linux-kernel" > CC: "linux-mtd" , "richard" > Gesendet: Mittwoch, 9. Oktober 2024 04:23:02 > Betreff: Re: [PATCH 1/1] ubifs: Try to recover from missing znode > =E5=9C=A8 2024/10/8 21:33, Benedikt Spranger =E5=86=99=E9=81=93: >> After powercut on a system using ubifs mounting failed: >>=20 >> 2024-09-30T12:38:26.880487+02:00 sonja kernel: UBIFS error (ubi0:0 pid 2= 178): >> ubifs_read_node [ubifs]: bad node type (255 but expected 9) >> 2024-09-30T12:38:26.880506+02:00 sonja kernel: UBIFS error (ubi0:0 pid 2= 178): >> ubifs_read_node [ubifs]: bad node at LEB 103:46920, LEB mapping status 0 >> 2024-09-30T12:38:26.880509+02:00 sonja kernel: Not a node, first 24 byte= s: >> 2024-09-30T12:38:26.880510+02:00 sonja kernel: 00000000: ff ff ff ff ff = ff ff ff >> ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff >> ........................ >>=20 >> While traversing over zbranches during the journal replay one zbranch >> points to a znode, which was not written to the flash and therefore the >> flash is empty. >=20 > UBIFS guarantees two things for znodes: > 1) all index nodes(in commit seq N) are written on flash before master > nodes(for commit seq N) are written. > 2) all index nodes(in commit seq N) won't be erased from flash before > master nodes(for commit seq N+1) are written. > So, I don't understand that why znodes not exist during journal replaying= ? In addition to that, is just one znode missing or are larger parts of the f= lash empty? Thanks, //richard