From: Adrian Hunter <adrian.hunter@intel.com>
To: Raul E Rangel <rrangel@chromium.org>, linux-mmc@vger.kernel.org
Cc: ernest.zhang@bayhubtech.com, djkurtz@chromium.org,
linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/3] mmc: sdhci: sdhci-pci-o2micro: Correctly set bus width when tuning
Date: Wed, 12 Jun 2019 15:53:57 +0300 [thread overview]
Message-ID: <883dab7b-57fc-22dd-e111-72506544d0e8@intel.com> (raw)
In-Reply-To: <20190610185354.35310-1-rrangel@chromium.org>
On 10/06/19 9:53 PM, Raul E Rangel wrote:
> sdhci_send_tuning uses mmc->ios.bus_width to determine the block size.
> Without this patch the block size would be set incorrectly when the
> bus_width == 8 which results in tuning failing.
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
> drivers/mmc/host/sdhci-pci-o2micro.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index b29bf4e7dcb48..dd21315922c87 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -115,6 +115,7 @@ static int sdhci_o2_execute_tuning(struct mmc_host *mmc, u32 opcode)
> */
> if (mmc->ios.bus_width == MMC_BUS_WIDTH_8) {
> current_bus_width = mmc->ios.bus_width;
> + mmc->ios.bus_width = MMC_BUS_WIDTH_4;
> sdhci_set_bus_width(host, MMC_BUS_WIDTH_4);
> }
>
> @@ -126,8 +127,10 @@ static int sdhci_o2_execute_tuning(struct mmc_host *mmc, u32 opcode)
>
> sdhci_end_tuning(host);
>
> - if (current_bus_width == MMC_BUS_WIDTH_8)
> + if (current_bus_width == MMC_BUS_WIDTH_8) {
> + mmc->ios.bus_width = MMC_BUS_WIDTH_8;
> sdhci_set_bus_width(host, current_bus_width);
> + }
>
> host->flags &= ~SDHCI_HS400_TUNING;
> return 0;
>
next prev parent reply other threads:[~2019-06-12 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 18:53 [PATCH 1/3] mmc: sdhci: sdhci-pci-o2micro: Correctly set bus width when tuning Raul E Rangel
2019-06-10 18:53 ` [PATCH 2/3] mmc: sdhci: sdhci-pci-o2micro: Check if controller supports 8-bit width Raul E Rangel
2019-06-12 13:09 ` Adrian Hunter
2019-06-12 15:08 ` Raul Rangel
2019-06-13 8:40 ` Adrian Hunter
2019-06-10 18:53 ` [PATCH 3/3] mmc: sdhci: Fix indenting on SDHCI_CTRL_8BITBUS Raul E Rangel
2019-06-12 13:12 ` Adrian Hunter
2019-06-12 13:42 ` Ulf Hansson
2019-06-12 12:53 ` Adrian Hunter [this message]
2019-06-12 13:36 ` [PATCH 1/3] mmc: sdhci: sdhci-pci-o2micro: Correctly set bus width when tuning Ulf Hansson
2019-06-12 15:01 ` Raul Rangel
2019-06-17 10:26 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=883dab7b-57fc-22dd-e111-72506544d0e8@intel.com \
--to=adrian.hunter@intel.com \
--cc=djkurtz@chromium.org \
--cc=ernest.zhang@bayhubtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rrangel@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.