Re: [PATCH v3 3/7] smb/client: mark file sparse before emulating insert range

[Paulo Alcantara <pc@manguebit.org>]

Hi Huiwen,

Huiwen He <huiwen.he@linux.dev> writes:

> From: Huiwen He <hehuiwen@kylinos.cn>
>
> The SMB client emulates FALLOC_FL_INSERT_RANGE with SET_EOF, COPYCHUNK
> and SET_ZERO_DATA.
>
> SET_ZERO_DATA creates a hole only when the file is sparse. On a
> non-sparse file, it clears the inserted range but leaves its blocks
> allocated, causing the extent count check in xfstests generic/064 to
> fail.
>
> Fix this by marking the file sparse before modifying it.
>
> Tested with xfstests generic/064 against Samba and ksmbd.

After applying this patch, generic/064 still fails for me against
samba-4.24.5-1.fc44.x86_64.  Tested it with both btrfs and xfs, and
'strict allocate = yes'.  It also fails against Windows Server 2022.

SECTION       -- smb3
FSTYP         -- cifs
PLATFORM      -- Linux/x86_64 fed 7.2.0 #4 SMP PREEMPT_DYNAMIC Wed Aug 26 21:42:48 -03 2026
MKFS_OPTIONS  -- //192.168.124.43/scratch2
MOUNT_OPTIONS -- -ousername=testuser,password=foo-321,vers=3.1.1,mfsymlinks,noperm //192.168.124.43/scratch2 /mnt/scratch

generic/064        - output mismatch (see /root/g/xfstests/results//smb3/generic/064.out.bad)
    --- tests/generic/064.out   2024-02-15 10:35:04.361833706 -0300
    +++ /root/g/xfstests/results//smb3/generic/064.out.bad      2026-08-26 21:58:54.469813041 -0300
    @@ -1,2 +1,3 @@
     QA output created by 064
    -Extent count after inserts is in range
    +Extent count after inserts has value of 1
    +Extent count after inserts is NOT in range 50 .. 53
    ...
    (Run 'diff -u /root/g/xfstests/tests/generic/064.out /root/g/xfstests/results//smb3/generic/064.out.bad'  to see the entire diff)
Ran: generic/064
Failures: generic/064
Failed 1 of 1 tests

What am I missing?

Could you please provide details of your server version and settings?

Thanks.