All of lore.kernel.org
 help / color / mirror / Atom feed
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	george.dunlap@citrix.com, Jun Nakajima <jun.nakajima@intel.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH V6 4/4] x86/altp2m: fix display frozen when switching to a new view early
Date: Fri, 16 Nov 2018 12:21:32 +0200	[thread overview]
Message-ID: <885ca18c-48eb-deae-462d-ea38c68cb51f@bitdefender.com> (raw)
In-Reply-To: <5BEE972D02000078001FCB0D@prv1-mh.provo.novell.com>

On 11/16/18 12:08 PM, Jan Beulich wrote:
> I've seen you mention such or alike a couple of times now while
> discussing this series, and I have to admit that I'm a little frightened:
> Making a change just based on the observation that nothing breaks
> is setting us up for breakage in some corner case. That is - seeing
> something break is a good indication that a change was wrong, but
> not seeing any breakage doesn't alone justify a change.
> 
> In the particular case here I think whether the copying of the field
> is needed depends on what else is being copied (I'm sorry, I'm not
> that familiar with altp2m): If mappings get cloned from the host p2m,
> then this value ought to be cloned too. For any mappings that
> might be kept in sync between p2m-s, I think this field also would
> need to be updated in sync.

I agree, I was merely offering to test whether any breakage occurs if
not syncing the field, not suggesting that that's a comprehensive
analysis or a justification for change, in case that offers us more insight.

AFAIK, EPT restrictions are always propagated from the hostp2m to all
active altp2ms. I've tested this at some point in the past and it has
proven true - it's supposedly an altp2m feature although it can also be
a bit of a headache: if we would have been able to use the hostp2m
independently then we wouldn't have had this display freeze problem,
since we could have used the hostp2m as the default (restricted) EPT
view. As things stand now, we need to create a new view when starting
introspection and switch to that immediately, so changes to it will not
propagate into other views (in other words, so we can use it
independently of all other altp2ms).


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-11-16 10:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14 20:39 [PATCH V6 0/4] Fix VGA logdirty related display freezes with altp2m Razvan Cojocaru
2018-11-14 20:39 ` [PATCH V6 1/4] x86/altp2m: propagate ept.ad changes to all active altp2ms Razvan Cojocaru
2018-11-14 20:40 ` [PATCH V6 2/4] x86/mm: introduce p2m_{init, free}_logdirty() Razvan Cojocaru
2018-11-15 16:21   ` George Dunlap
2018-11-14 20:40 ` [PATCH V6 3/4] x86/mm: allocate logdirty_ranges for altp2ms Razvan Cojocaru
2018-11-15 10:56   ` Jan Beulich
2018-11-15 12:14     ` Razvan Cojocaru
2018-11-15 15:52   ` George Dunlap
2018-11-15 16:21     ` Razvan Cojocaru
2018-11-14 20:40 ` [PATCH V6 4/4] x86/altp2m: fix display frozen when switching to a new view early Razvan Cojocaru
2018-11-15 17:34   ` George Dunlap
2018-11-15 17:54     ` Razvan Cojocaru
2018-11-16 10:08       ` Jan Beulich
2018-11-16 10:21         ` Razvan Cojocaru [this message]
2018-11-16 12:03         ` George Dunlap
2018-11-16 12:26           ` Razvan Cojocaru
2018-11-16 12:31           ` Jan Beulich
2018-11-16 15:05             ` George Dunlap
2018-11-16 15:52               ` George Dunlap
2018-11-19 12:42                 ` Jan Beulich
2018-11-19 13:01                   ` Razvan Cojocaru
2018-11-16 14:10           ` Razvan Cojocaru
2018-11-16 17:59             ` George Dunlap
2018-11-16 19:50               ` Razvan Cojocaru
2018-11-17 18:58                 ` Razvan Cojocaru
2018-11-19 15:58                   ` George Dunlap
2018-11-19 16:17                     ` Razvan Cojocaru
2018-11-19 16:49                       ` George Dunlap
2018-11-15 20:26   ` George Dunlap
2018-11-15 20:51     ` Razvan Cojocaru
2018-11-16 12:20       ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=885ca18c-48eb-deae-462d-ea38c68cb51f@bitdefender.com \
    --to=rcojocaru@bitdefender.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.