Re: [PATCH net v2] net: macb: rate limit netdev error info print in the data path

[Nicolai Buchwitz <nb@tipi-net.de>]

On 7.10.2026 07:52, taozj888 wrote:

> [...]

>>>>> This will just hide the error message, but the split/drop is still
>>>>> present.
>>>>> How about limiting JML in macb_init_hw() properly?
>>>>> 
>>>>>          if ((bp->caps & MACB_CAPS_JUMBO) && bp->jumbo_max_len) {
>>>>>                  u32 jml = bp->rx_buffer_size - NET_IP_ALIGN +
>>>>> ETH_FCS_LEN;
>>>>>                  gem_writel(bp, JML, min(jml, bp->jumbo_max_len));
>>>>>          }
>>>>> 
>>>>> The code above is untested, so probably needs further tweaking. An
>>>>> alternative could
>>>>> be to handle the split frames in gem_rx() correctly.
>>>> 
>>>> I agree with you but to clarify for Zijin: if you do this then it
>>>> should
>>>> be a separate patch as changes are pretty unrelated.
>>> 
>>> Yes, with your experience in this area, maybe a separate patch for it
>>> is preferred.
>>> I think the error reported is not just related the Jumbo frame, but 
>>> the
>>> jumbo frame
>>> would trigger the error. So rate limit printing this kind of msg is
>>> needed but not
>>> totally hide those msgs.
>> 
>> Which other cases do you have in mind?
>> 
>> Rate limiting the message in this patch is fine with me. I can look
>> into the JML patch separately, or you can give it a try.
>> 
> 
>>> [...]
> 
> 
> Currently I have not direct cases here, but for some tough network 
> environmets,
> there may be some error pkts received, especially for our customed 
> HW/SW network requirement
> which may trigger this kind of message.

If possible, can you tell more about these custom HW/SW requirements 
regarding the macb?

> [...]

Thanks,
Nicolai