All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, stefanha@redhat.com
Subject: Re: [PATCH 0/2] virtio-scsi: Implement FC_HOST feature
Date: Mon, 16 Jan 2017 15:17:59 -0500 (EST)	[thread overview]
Message-ID: <886576564.9475841.1484597879593.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <0009b36c-29a9-9486-3fad-197733d905bc@suse.de>


> How it this supposed to work?
> You do export the WWPN/WWNN of the associated host to the guest (nb:
> will get interesting for non NPIV setups ...), but virtio scsi will
> still do a LUN remapping.
> IE the LUNs you see on the host will be different from the LUNs
> presented to the guest.

This is taken care of in the host by presenting to the host all LUNs from
a host's NPIV vHBA.  (Libvirt probably would be the one taking care of this,
because QEMU may not have enough permissions).

> Plus you don't _actually_ expose the FC host, but rather the WWPN of the
> host presenting the LUN.
> So how do you handle LUNs from different FC hosts on the guest?

I'm not sure I understand.

Neither I nor Fam know this stuff very well, but we are trying to do the same
as Hyper-V (and other proprietary hypervisors too).

> Overall, I'm not overly happy with this approach.
> You already added WWPN ids to the virtio transport, so why didn't you
> update the LUN field, too, to avoid this ominous LUN remapping?

Is this your old idea of adding a separate target field to commands,
in order to support 64-bit LUNs?  That is separate, and most FC drivers
only default to 16-bit LUNs anyway.

> And we really should make sure to have a single FC host in the guest
> presenting all LUNs.

Yes, of course.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Fam Zheng <famz@redhat.com>,
	linux-kernel@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	virtualization@lists.linux-foundation.org, stefanha@redhat.com
Subject: Re: [PATCH 0/2] virtio-scsi: Implement FC_HOST feature
Date: Mon, 16 Jan 2017 15:17:59 -0500 (EST)	[thread overview]
Message-ID: <886576564.9475841.1484597879593.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <0009b36c-29a9-9486-3fad-197733d905bc@suse.de>


> How it this supposed to work?
> You do export the WWPN/WWNN of the associated host to the guest (nb:
> will get interesting for non NPIV setups ...), but virtio scsi will
> still do a LUN remapping.
> IE the LUNs you see on the host will be different from the LUNs
> presented to the guest.

This is taken care of in the host by presenting to the host all LUNs from
a host's NPIV vHBA.  (Libvirt probably would be the one taking care of this,
because QEMU may not have enough permissions).

> Plus you don't _actually_ expose the FC host, but rather the WWPN of the
> host presenting the LUN.
> So how do you handle LUNs from different FC hosts on the guest?

I'm not sure I understand.

Neither I nor Fam know this stuff very well, but we are trying to do the same
as Hyper-V (and other proprietary hypervisors too).

> Overall, I'm not overly happy with this approach.
> You already added WWPN ids to the virtio transport, so why didn't you
> update the LUN field, too, to avoid this ominous LUN remapping?

Is this your old idea of adding a separate target field to commands,
in order to support 64-bit LUNs?  That is separate, and most FC drivers
only default to 16-bit LUNs anyway.

> And we really should make sure to have a single FC host in the guest
> presenting all LUNs.

Yes, of course.

Paolo

  reply	other threads:[~2017-01-16 20:17 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 16:04 [PATCH 0/2] virtio-scsi: Implement FC_HOST feature Fam Zheng
2017-01-16 16:04 ` [PATCH 1/2] virtio_scsi: Add fc_host definitions Fam Zheng
2017-01-16 16:04   ` Fam Zheng
2017-01-16 16:04 ` [PATCH 2/2] virtio_scsi: Implement fc_host Fam Zheng
2017-01-16 16:04   ` Fam Zheng
2017-01-16 16:45   ` Paolo Bonzini
2017-01-16 16:45     ` Paolo Bonzini
2017-01-16 17:26     ` Fam Zheng
2017-01-16 17:26     ` Fam Zheng
2017-01-17 13:17       ` Paolo Bonzini
2017-01-17 14:05         ` Fam Zheng
2017-01-17 14:05           ` Fam Zheng
2017-01-17 15:47           ` Michael S. Tsirkin
2017-01-17 15:47           ` Michael S. Tsirkin
2017-01-17 13:17       ` Paolo Bonzini
2017-01-16 19:02   ` kbuild test robot
2017-01-16 19:02     ` kbuild test robot
2017-01-17  3:40     ` Fam Zheng
2017-01-17  3:40       ` Fam Zheng
2017-01-16 20:24   ` kbuild test robot
2017-01-16 20:24     ` kbuild test robot
2017-01-16 17:34 ` [PATCH 0/2] virtio-scsi: Implement FC_HOST feature Christoph Hellwig
2017-01-16 17:34   ` Christoph Hellwig
2017-01-17  3:37   ` Fam Zheng
2017-01-17  3:37   ` Fam Zheng
2017-01-16 17:44 ` Hannes Reinecke
2017-01-16 17:44   ` Hannes Reinecke
2017-01-16 17:44   ` Hannes Reinecke
2017-01-16 20:17   ` Paolo Bonzini [this message]
2017-01-16 20:17     ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2017-01-16 16:04 Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=886576564.9475841.1484597879593.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mst@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.