From: David Howells <dhowells@redhat.com>
To: "Reshetova, Elena" <elena.reshetova@intel.com>
Cc: dhowells@redhat.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-afs@lists.infradead.org" <linux-afs@lists.infradead.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Hans Liljestrand <ishkamiel@gmail.com>,
"Kees Cook" <keescook@chromium.org>,
David Windsor <dwindsor@gmail.com>
Subject: Re: [PATCH 1/4] fs, afs: convert afs_cell.usage from atomic_t to refcount_t
Date: Wed, 22 Feb 2017 17:29:14 +0000 [thread overview]
Message-ID: <8877.1487784554@warthog.procyon.org.uk> (raw)
In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B41C4EF59@IRSMSX102.ger.corp.intel.com>
Reshetova, Elena <elena.reshetova@intel.com> wrote:
> Thank you very much David for testing the patches!
> I guess for this one and other two patches it means that if we want to do the atomic_t --> refcount_t conversions,
> we need to do +1 on the whole counting scheme to avoid issues around reaching zero.
> Do you see this approach reasonable? I can give it a try, if it makes sense in your opinion.
Or you could create a refcount_inc_may_resurrect() function that does allow
increment from 0. Make it take a lock-check like the rcu functions do.
David
next prev parent reply other threads:[~2017-02-22 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 15:43 [PATCH 0/4] fs, afs subsystem refcounter conversions Elena Reshetova
2017-02-21 15:43 ` [PATCH 1/4] fs, afs: convert afs_cell.usage from atomic_t to refcount_t Elena Reshetova
2017-02-22 16:16 ` David Howells
2017-02-22 17:19 ` Reshetova, Elena
2017-02-22 17:29 ` David Howells [this message]
2017-02-22 17:39 ` Kees Cook
2017-02-23 13:32 ` Reshetova, Elena
2017-02-24 14:21 ` David Howells
2017-02-21 15:43 ` [PATCH 2/4] fs, afs: convert afs_vlocation.usage " Elena Reshetova
2017-02-22 16:22 ` David Howells
2017-02-21 15:43 ` [PATCH 3/4] fs, afs: convert afs_server.usage " Elena Reshetova
2017-02-22 16:32 ` David Howells
2017-02-23 14:05 ` Reshetova, Elena
2017-02-21 15:43 ` [PATCH 4/4] fs, afs: convert afs_volume.usage " Elena Reshetova
2017-02-22 16:34 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8877.1487784554@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dwindsor@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ishkamiel@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.