From: Jens Axboe <axboe@kernel.dk>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-aio@kvack.org, Jeff Moyer <jmoyer@redhat.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PTACH] fs: get rid of the res2 iocb->ki_complete argument
Date: Mon, 25 Oct 2021 10:38:24 -0600 [thread overview]
Message-ID: <887851ee-e144-1186-76d6-b110c445c540@kernel.dk> (raw)
In-Reply-To: <20211025161629.GA2237511@magnolia>
On 10/25/21 10:16 AM, Darrick J. Wong wrote:
> On Mon, Oct 25, 2021 at 09:33:02AM -0600, Jens Axboe wrote:
>> The second argument was only used by the USB gadget code, yet everyone
>> pays the overhead of passing a zero to be passed into aio, where it
>> ends up being part of the aio res2 value.
>>
>> Now that everybody is passing in zero, kill off the extra argument.
>>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> The fs/ parts look reasonable to me.
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Thanks!
> So, uh, do you get even more iops by avoiding the extra register? :)
Heh, well if you're register starved, it'll likely make a bigger
difference, but even on my CPU it is actually noticeable. Obviously not
a 10% gain, and the change is more about cleaning up the API a bit.
--
Jens Axboe
prev parent reply other threads:[~2021-10-25 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 15:33 [PTACH] fs: get rid of the res2 iocb->ki_complete argument Jens Axboe
2021-10-25 16:16 ` Darrick J. Wong
2021-10-25 16:38 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887851ee-e144-1186-76d6-b110c445c540@kernel.dk \
--to=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.