From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: <linux-kernel@vger.kernel.org>
Cc: <mingo@redhat.com>, <tglx@linutronix.de>,
Srinivas REDDY Eeda <srinivas.eeda@oracle.com>, <bp@alien8.de>,
<hpa@zytor.com>
Subject: [PATCH] x86/microcode/intel: Fix memleak in save_microcode_patch
Date: Thu, 31 May 2018 21:51:05 -0700 (PDT) [thread overview]
Message-ID: <888102f0-fd22-459d-b090-a1bd8a00cb2b@default> (raw)
Free useless ucode_patch entry when it's replaced.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
arch/x86/kernel/cpu/microcode/intel.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index 1c2cfa0..461e315 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -150,6 +150,12 @@ static bool microcode_matches(struct microcode_header_intel *mc_header,
return false;
}
+static void memfree_patch(struct ucode_patch *p)
+{
+ kfree(p->data);
+ kfree(p);
+}
+
static struct ucode_patch *memdup_patch(void *data, unsigned int size)
{
struct ucode_patch *p;
@@ -190,8 +196,10 @@ static void save_microcode_patch(void *data, unsigned int size)
p = memdup_patch(data, size);
if (!p)
pr_err("Error allocating buffer %p\n", data);
- else
+ else {
list_replace(&iter->plist, &p->plist);
+ memfree_patch(iter);
+ }
}
}
--
1.7.1
next reply other threads:[~2018-06-01 4:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 4:51 Zhenzhong Duan [this message]
2018-06-01 7:12 ` [PATCH] x86/microcode/intel: Fix memleak in save_microcode_patch Borislav Petkov
2018-06-22 12:45 ` [tip:x86/urgent] x86/microcode/intel: Fix memleak in save_microcode_patch() tip-bot for Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=888102f0-fd22-459d-b090-a1bd8a00cb2b@default \
--to=zhenzhong.duan@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=srinivas.eeda@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.