From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver Date: Wed, 27 Jun 2012 22:27:23 +0200 Message-ID: <8882387.r1uUUpi6dA@avalon> References: <1338381179-13290-1-git-send-email-laurent.pinchart@ideasonboard.com> <1346173.UfsXpaZxOr@avalon> <4FEB67DE.2040103@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id 013E79E828 for ; Wed, 27 Jun 2012 13:27:19 -0700 (PDT) In-Reply-To: <4FEB67DE.2040103@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Lars-Peter Clausen Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Lars-Peter, On Wednesday 27 June 2012 22:06:54 Lars-Peter Clausen wrote: > On 06/27/2012 02:40 PM, Laurent Pinchart wrote: > > Hi Lars-Peter, > > > > [...] > > > > Do you plan to post a v3 of your "DRM: Add DRM kms/fb cma helper" patch in > > the near future ? > > Hi Laurent, > > I don't think there have been any changes since v2 except for adjusting to > the renamed functions in Sascha's patch. I'll send a v3 tomorrow. OK, thanks. As Ville pointed out, we need to validate the offsets and make sure the frame buffer fits in the GEM object(s). I don't think there's code in your patch to do so, have you thought about where/how to implement that ? > I think it makes most sense if you carry these two patches (Sascha's and > mine) as part of your "Renesas SH Mobile DRM driver" series, so reviewers > can see it in context. OK I'll do that. -- Regards, Laurent Pinchart